Revert #7212 as its IT fails in Flow 1.0

vaadin · Jan 9, 2020 · 21db2d5 · 21db2d5
1 parent 826a312
commit 21db2d5
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 109 deletions.
diff --git a/flow-server/src/main/java/com/vaadin/flow/dom/Element.java b/flow-server/src/main/java/com/vaadin/flow/dom/Element.java
@@ -19,7 +19,6 @@
 import java.util.HashMap;
 import java.util.Locale;
 import java.util.Map;
-import java.util.Objects;
 import java.util.Optional;
 import java.util.Set;
 import java.util.function.Predicate;
@@ -723,12 +722,7 @@ private Element setRawProperty(String name, Serializable value) {
         verifySetPropertyName(name);
 
         if ("innerHTML".equals(name)) {
-            Serializable oldValue = getStateProvider()
-                    .getProperty(getNode(), name);
-            if(!Objects.equals(value, oldValue)) {
-                // Only remove all children for value change
-                removeAllChildren();
-            }
+            removeAllChildren();
         }
         getStateProvider().setProperty(getNode(), name, value, true);
 

diff --git a/...tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/ElementInnerHtmlView.java b/...tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/ElementInnerHtmlView.java
diff --git a/flow-tests/test-root-context/src/test/java/com/vaadin/flow/uitest/ui/ElementInnerHtmlIT.java b/flow-tests/test-root-context/src/test/java/com/vaadin/flow/uitest/ui/ElementInnerHtmlIT.java