Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@Layout components are not included in the production bundle #20074

Closed
Artur- opened this issue Sep 27, 2024 · 1 comment · Fixed by #20076
Closed

@Layout components are not included in the production bundle #20074

Artur- opened this issue Sep 27, 2024 · 1 comment · Fixed by #20076
Labels
bug Impact: High prerelease version for Vaadin 24.5.0 Released with Vaadin 24.5.0.beta4 Severity: Blocker

Comments

@Artur-
Copy link
Member

Artur- commented Sep 27, 2024

Description of the bug

When you use @Layout then all components only used in the layout are missing from the production bundle

The code here

flow/flow-server/src/main/java/com/vaadin/flow/server/frontend/scanner/FrontendDependencies.java

Line 440 in 4844adb

private void collectEntryPoints(boolean generateEmbeddableWebComponents)
use @Route and other classes as entry points but does not seem to consider @Layout

Expected behavior

The layout components are included

Minimal reproducible example

Any app using @Layout + AppLayout + SideNav look like this in production
image

Versions

24.5 beta 3
@mshabarov mshabarov self-assigned this Sep 27, 2024
caalador added a commit that referenced this issue Sep 27, 2024
@caalador
fix: Layout should be collected as entyrpoint
5473f90 
Layout annotated classes should be
collected as entrypoints for
production builds.

Fixes #20074
@caalador caalador mentioned this issue Sep 27, 2024
Merged
caalador added a commit that referenced this issue Sep 27, 2024
@caalador
fix: Layout should be collected as entyrpoint
586d0b9 
Layout annotated classes should be
collected as entrypoints for
production builds.

Fixes #20074
mshabarov pushed a commit that referenced this issue Sep 27, 2024
@caalador
fix: Layout should be collected as entyrpoint (#20076)
d91be76 
Layout annotated classes should be
collected as entrypoints for
production builds.

Fixes #20074
vaadin-bot pushed a commit that referenced this issue Sep 27, 2024
@caalador @vaadin-bot
fix: Layout should be collected as entyrpoint (#20076)
6c47542 
Layout annotated classes should be
collected as entrypoints for
production builds.

Fixes #20074
@mshabarov mshabarov removed their assignment Sep 27, 2024
vaadin-bot added a commit that referenced this issue Sep 27, 2024
@vaadin-bot @caalador
fix: Layout should be collected as entyrpoint (#20076) (#20079)
59bf5c5 
Layout annotated classes should be
collected as entrypoints for
production builds.

Fixes #20074

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.beta4 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Impact: High prerelease version for Vaadin 24.5.0 Released with Vaadin 24.5.0.beta4 Severity: Blocker
Projects
Vaadin Flow bugs & maintenance (Vaadin 10+)
Status: ✅ Closed
Vaadin Flow ongoing work (Vaadin 10+)
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Layout should be collected as entyrpoint vaadin/flow
3 participants
@Artur- @vaadin-bot @mshabarov