Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove validation status change listener upon unbind #14111

Merged
merged 5 commits into from
Jul 1, 2022
Merged

feat: remove validation status change listener upon unbind #14111

merged 5 commits into from
Jul 1, 2022

Conversation

taefi
Copy link
Contributor

@taefi taefi commented Jun 30, 2022 •
edited
Loading

Description

Listener removal was missing when unbinding
was happening. Follow up for #13940.

Fixes #14110

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed a self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@taefi
feat: remove validation status change listener upon unbind
0a8b78d 
Listener removal was missing when unbind
was happening.
@taefi taefi mentioned this pull request Jun 30, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jun 30, 2022 •
edited
Loading

Unit Test Results

   902 files  ±0     902 suites  ±0   56m 9s ⏱️ + 5m 34s
5 884 tests +1  5 840 ✔️ ±0  44 💤 +1  0 ❌ ±0 
6 094 runs  +3  6 044 ✔️ +2  50 💤 +1  0 ❌ ±0 

Results for commit 74e3854. ± Comparison against base commit f298ede.

♻️ This comment has been updated with latest results.

@taefi taefi marked this pull request as ready for review July 1, 2022 14:41
@taefi taefi requested a review from mcollovati July 1, 2022 14:44
@sonarcloud
Copy link

sonarcloud bot commented Jul 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mcollovati mcollovati merged commit b3a03f0 into master Jul 1, 2022
@mcollovati mcollovati deleted the remove-vldtn-stts-chng-lstnr-upon-unbind branch July 1, 2022 15:25
vaadin-bot pushed a commit that referenced this pull request Jul 1, 2022
@taefi @vaadin-bot
feat: remove validation status change listener upon unbind (#14111)
26fa1c1 
Listener removal was missing when unbind
was happening.

Fixes #14110
vaadin-bot pushed a commit that referenced this pull request Jul 1, 2022
@taefi @vaadin-bot
feat: remove validation status change listener upon unbind (#14111)
6c8b50b 
Listener removal was missing when unbind
was happening.

Fixes #14110
vaadin-bot pushed a commit that referenced this pull request Jul 1, 2022
@taefi @vaadin-bot
feat: remove validation status change listener upon unbind (#14111)
425c235 
Listener removal was missing when unbind
was happening.

Fixes #14110
vaadin-bot pushed a commit that referenced this pull request Jul 1, 2022
@taefi @vaadin-bot
feat: remove validation status change listener upon unbind (#14111)
bed5c85 
Listener removal was missing when unbind
was happening.

Fixes #14110
vaadin-bot pushed a commit that referenced this pull request Jul 1, 2022
@taefi @vaadin-bot
feat: remove validation status change listener upon unbind (#14111)
4ed6175 
Listener removal was missing when unbind
was happening.

Fixes #14110
mcollovati pushed a commit that referenced this pull request Jul 1, 2022
@vaadin-bot @taefi
feat: remove validation status change listener upon unbind (#14111) (#…
f0bb6d0 
…14128)

Listener removal was missing when unbind
was happening.

Fixes #14110

Co-authored-by: Soroosh Taefi <taefi.soroosh@gmail.com>
mcollovati pushed a commit that referenced this pull request Jul 1, 2022
@vaadin-bot @taefi
feat: remove validation status change listener upon unbind (#14111) (#…
cc8e936 
…14131)

Listener removal was missing when unbind
was happening.

Fixes #14110

Co-authored-by: Soroosh Taefi <taefi.soroosh@gmail.com>
mcollovati pushed a commit that referenced this pull request Jul 1, 2022
@vaadin-bot
feat: remove validation status change listener upon unbind (#14111) (#…
f9cd173 
…14129)

Listener removal was missing when unbind
was happening.

Fixes #14110
mcollovati pushed a commit that referenced this pull request Jul 1, 2022
@vaadin-bot
feat: remove validation status change listener upon unbind (#14111) (#…
3706627 
…14130)

Listener removal was missing when unbind
was happening.

Fixes #14110
mcollovati pushed a commit that referenced this pull request Jul 1, 2022
@vaadin-bot
feat: remove validation status change listener upon unbind (#14111) (#…
3cfcd8c 
…14132)

Listener removal was missing when unbind
was happening.

Fixes #14110
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 23.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollovati mcollovati mcollovati approved these changes

Assignees
No one assigned
Labels
cherry-picked-2.7 cherry-picked-2.8 cherry-picked-9.0 cherry-picked-23.0 cherry-picked-23.1 Released with Vaadin 23.2.0 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider removing the ValidationStatusChangeListener when unbind happens
3 participants
@taefi @vaadin-bot @mcollovati