Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add translation file request handler #18680

Merged
merged 59 commits into from
Mar 1, 2024
Merged

feat: add translation file request handler #18680

merged 59 commits into from
Mar 1, 2024

Commits on Feb 21, 2024

  1. feat: add translation file request handler

    @ugur-vaadin
    ugur-vaadin committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    b9df16b View commit details
    Browse the repository at this point in the history

  2. refactor: remove static keyword for consistency

    @ugur-vaadin
    ugur-vaadin committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    1f925fc View commit details
    Browse the repository at this point in the history

  3. refactor: introduce translation file request enum and constant

    @ugur-vaadin
    ugur-vaadin committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    708934d View commit details
    Browse the repository at this point in the history

  4. refactor: use language tag instead of separate params

    @ugur-vaadin
    ugur-vaadin committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    d57c40f View commit details
    Browse the repository at this point in the history

  5. refactor: lower severity of missing bundle log

    @ugur-vaadin
    ugur-vaadin committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    8921243 View commit details
    Browse the repository at this point in the history

  6. refactor: add retrieved locale to response

    @ugur-vaadin
    ugur-vaadin committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    bee92a8 View commit details
    Browse the repository at this point in the history

  7. refactor: increase logging severity for missing resource bundle

    @ugur-vaadin
    ugur-vaadin committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    5cf1409 View commit details
    Browse the repository at this point in the history

  8. chore: add missing default bundle to log message

    @ugur-vaadin
    ugur-vaadin committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    6637608 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. test: add tests for system default locale and rename default bundle

    @ugur-vaadin
    ugur-vaadin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    aa95f56 View commit details
    Browse the repository at this point in the history

  2. chore: run formatter

    @ugur-vaadin
    ugur-vaadin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    6f93215 View commit details
    Browse the repository at this point in the history

  3. refactor: only use the root locale as the fallback locale

    @ugur-vaadin
    ugur-vaadin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    0a35ceb View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. chore: do not use wildcard imports

    @ugur-vaadin
    ugur-vaadin committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    d6d80d1 View commit details
    Browse the repository at this point in the history

  2. refactor: update retrieved locale header name

    @ugur-vaadin
    ugur-vaadin committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    08696ed View commit details
    Browse the repository at this point in the history

  3. fix: handle translation file requests only for default i18n provider

    @ugur-vaadin
    ugur-vaadin committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    43fd67c View commit details
    Browse the repository at this point in the history

  4. test: mock service to fix tests

    @ugur-vaadin
    ugur-vaadin committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    c2c0f9c View commit details
    Browse the repository at this point in the history

  5. test: fix i18nprovider mocking

    @ugur-vaadin
    ugur-vaadin committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    d6d232f View commit details
    Browse the repository at this point in the history

  6. chore: remove unused imports

    @ugur-vaadin
    ugur-vaadin committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    a3021dd View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. refactor: check i18n provider when initializing handlers

    @ugur-vaadin
    ugur-vaadin committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    a1e201a View commit details
    Browse the repository at this point in the history

  2. refactor: make getbundle package private

    @ugur-vaadin
    ugur-vaadin committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    75e5810 View commit details
    Browse the repository at this point in the history

  3. refactor: set i18n provider to handler and handle custom provider

    @ugur-vaadin
    ugur-vaadin committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    4437b9f View commit details
    Browse the repository at this point in the history

  4. test: add test for custom i18n provider

    @ugur-vaadin
    ugur-vaadin committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    1a53762 View commit details
    Browse the repository at this point in the history

  5. test: rename tests

    @ugur-vaadin
    ugur-vaadin committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    aeae7ca View commit details
    Browse the repository at this point in the history

  6. refactor: add prod case and update status codes for custom i18n provider

    @ugur-vaadin
    ugur-vaadin committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    1fdc530 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Update flow-server/src/main/java/com/vaadin/flow/i18n/TranslationFile… 

    …RequestHandler.java

Co-authored-by: Marco Collovati <marco@vaadin.com>
    @ugur-vaadin @mcollovati
    ugur-vaadin and mcollovati authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    049b232 View commit details
    Browse the repository at this point in the history

  2. Update flow-server/src/main/java/com/vaadin/flow/i18n/TranslationFile… 

    …RequestHandler.java

Co-authored-by: Marco Collovati <marco@vaadin.com>
    @ugur-vaadin @mcollovati
    ugur-vaadin and mcollovati authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    3dfd498 View commit details
    Browse the repository at this point in the history

  3. Update flow-server/src/test/java/com/vaadin/flow/i18n/TranslationFile… 

    …RequestHandlerTest.java

Co-authored-by: Marco Collovati <marco@vaadin.com>
    @ugur-vaadin @mcollovati
    ugur-vaadin and mcollovati authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    f2ad135 View commit details
    Browse the repository at this point in the history

  4. Update flow-server/src/main/java/com/vaadin/flow/i18n/TranslationFile… 

    …RequestHandler.java

Co-authored-by: Marco Collovati <marco@vaadin.com>
    @ugur-vaadin @mcollovati
    ugur-vaadin and mcollovati authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    71d2f8f View commit details
    Browse the repository at this point in the history

  5. Update flow-server/src/main/java/com/vaadin/flow/i18n/TranslationFile… 

    …RequestHandler.java

Co-authored-by: Marco Collovati <marco@vaadin.com>
    @ugur-vaadin @mcollovati
    ugur-vaadin and mcollovati authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    733d9f9 View commit details
    Browse the repository at this point in the history

  6. refactor: extend synchronized request handler

    @ugur-vaadin
    ugur-vaadin committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    4ee0525 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'feat-add-translation-file-request-handler' of https://g… 

    …ithub.com/vaadin/flow into feat-add-translation-file-request-handler
    @ugur-vaadin
    ugur-vaadin committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    8ec3506 View commit details
    Browse the repository at this point in the history

  8. refactor: return not implemented for custom i18n provider when not in… 

    … prod
    @ugur-vaadin
    ugur-vaadin committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    5bc27b1 View commit details
    Browse the repository at this point in the history

  9. Update flow-server/src/main/java/com/vaadin/flow/server/VaadinService… 

    ….java

Co-authored-by: Marco Collovati <marco@vaadin.com>
    @ugur-vaadin @mcollovati
    ugur-vaadin and mcollovati authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    fe28472 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'feat-add-translation-file-request-handler' of https://g… 

    …ithub.com/vaadin/flow into feat-add-translation-file-request-handler
    @ugur-vaadin
    ugur-vaadin committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    9cb6f08 View commit details
    Browse the repository at this point in the history

  11. Update flow-server/src/test/java/com/vaadin/flow/i18n/TranslationFile… 

    …RequestHandlerTest.java

Co-authored-by: Marco Collovati <marco@vaadin.com>
    @ugur-vaadin @mcollovati
    ugur-vaadin and mcollovati authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    6e10668 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'feat-add-translation-file-request-handler' of https://g… 

    …ithub.com/vaadin/flow into feat-add-translation-file-request-handler
    @ugur-vaadin
    ugur-vaadin committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    a4c6a70 View commit details
    Browse the repository at this point in the history

  13. chore: do not use wildcard in imports

    @ugur-vaadin
    ugur-vaadin committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    c3a3cf2 View commit details
    Browse the repository at this point in the history

  14. Update flow-server/src/test/java/com/vaadin/flow/i18n/TranslationFile… 

    …RequestHandlerTest.java

Co-authored-by: Marco Collovati <marco@vaadin.com>
    @ugur-vaadin @mcollovati
    ugur-vaadin and mcollovati authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    314499e View commit details
    Browse the repository at this point in the history

  15. Merge branch 'feat-add-translation-file-request-handler' of https://g… 

    …ithub.com/vaadin/flow into feat-add-translation-file-request-handler
    @ugur-vaadin
    ugur-vaadin committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    5353f94 View commit details
    Browse the repository at this point in the history

  16. chore: run formatter

    @ugur-vaadin
    ugur-vaadin committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    93090ef View commit details
    Browse the repository at this point in the history

  17. test: add tests for verifying response status codes

    @ugur-vaadin
    ugur-vaadin committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    a4e164f View commit details
    Browse the repository at this point in the history

  18. test: add failure messages to response content assertions

    @ugur-vaadin
    ugur-vaadin committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    d5c9edb View commit details
    Browse the repository at this point in the history

  19. refactor: add underscore in language tag support

    @ugur-vaadin
    ugur-vaadin committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    21235c4 View commit details
    Browse the repository at this point in the history

  20. refactor: return bundle for partial locale match

    @ugur-vaadin
    ugur-vaadin committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    bb424a8 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. chore: run formatter

    @ugur-vaadin
    ugur-vaadin committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    6bc4f00 View commit details
    Browse the repository at this point in the history

  2. refactor: fix and clarify missing locale logs

    @ugur-vaadin
    ugur-vaadin committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    b39e6ea View commit details
    Browse the repository at this point in the history

  3. test: add tests for unavailable language tags with underscores

    @ugur-vaadin
    ugur-vaadin committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    4bed9de View commit details
    Browse the repository at this point in the history

  4. test: refactor initializing block

    @ugur-vaadin
    ugur-vaadin committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    52f26c0 View commit details
    Browse the repository at this point in the history

  5. refactor: check for exact match in i18n provider when handling

    @ugur-vaadin
    ugur-vaadin committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    fcfa250 View commit details
    Browse the repository at this point in the history

  6. docs: add javadoc for the handler

    @ugur-vaadin
    ugur-vaadin committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    6fc8aa1 View commit details
    Browse the repository at this point in the history

  7. docs: further clarify the parameter and response header

    @ugur-vaadin
    ugur-vaadin committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    2543e09 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Merge branch 'main' into feat-add-translation-file-request-handler

    @mcollovati
    mcollovati authored Mar 1, 2024
    Configuration menu
    Copy the full SHA
    3be0cbe View commit details
    Browse the repository at this point in the history

  2. refactor: check for i18n provider class and fallback bundle in constr… 

    …uctor
    @ugur-vaadin
    ugur-vaadin committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    c888d9b View commit details
    Browse the repository at this point in the history

  3. test: refactor and cleanup tests

    @ugur-vaadin
    ugur-vaadin committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    f2f2cc2 View commit details
    Browse the repository at this point in the history

  4. test: add tests for empty language tags

    @ugur-vaadin
    ugur-vaadin committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    0dfd516 View commit details
    Browse the repository at this point in the history

  5. Update flow-server/src/main/java/com/vaadin/flow/i18n/TranslationFile… 

    …RequestHandler.java

Co-authored-by: Marco Collovati <marco@vaadin.com>
    @ugur-vaadin @mcollovati
    ugur-vaadin and mcollovati authored Mar 1, 2024
    Configuration menu
    Copy the full SHA
    bbb5560 View commit details
    Browse the repository at this point in the history

  6. refactor: make fields private

    @ugur-vaadin
    ugur-vaadin committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    aaf1f74 View commit details
    Browse the repository at this point in the history

  7. fix: separate logs for fallback bundles and best match bundles

    @ugur-vaadin
    ugur-vaadin committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    e012c19 View commit details
    Browse the repository at this point in the history

  8. refactor: add one more log case and use placeholders

    @ugur-vaadin
    ugur-vaadin committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    ff459d9 View commit details
    Browse the repository at this point in the history

  9. chore: simplify logs and use default bundle to indicate the fallback … 

    …bundle
    @ugur-vaadin
    ugur-vaadin committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    543417f View commit details
    Browse the repository at this point in the history