-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Move default frontend to src/main #18803
Conversation
Move frontend folder from root to src/main. Closes #18436
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments.
Plus the following leftovers for "frontend" are still there:
- In
ExternalDependencyWatcher
class the folder is hardcoded DeploymentConfigurationFactoryTest
the same, "frontend" hardcoded
Also, I tried this change with the hybrid and Flow apps, and it doesn't break them. Nothing is changed and they work as previously.
So in what cases this is a breaking change?
Can we merge this immediately without smart detection?
flow-server/src/main/java/com/vaadin/flow/server/frontend/FrontendUtils.java
Outdated
Show resolved
Hide resolved
flow-server/src/main/resources/com/vaadin/flow/server/frontend/tsconfig-v23.3.4-hilla.json
Outdated
Show resolved
Hide resolved
flow-server/src/main/resources/com/vaadin/flow/server/frontend/tsconfig-v23.3.4.json
Outdated
Show resolved
Hide resolved
flow-server/src/main/resources/plugins/theme-live-reload-plugin/theme-live-reload-plugin.js
Show resolved
Hide resolved
flow-server/src/main/resources/plugins/theme-live-reload-plugin/theme-live-reload-plugin.js
Outdated
Show resolved
Hide resolved
ExternalDependencyWatcher mentions frontend for metaInfFolder e.g META-INF and not the project frontend folder. For the unified execution check that the plugin is using the correct code for the frontend folders. it should not work with having frontend in ./frontend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I propose to rebase the second PR onto this, and merge the second PR.
Let me test it locally.
Quality Gate passedIssues Measures |
This ticket/PR has been released with Vaadin 24.4.0. |
Move frontend folder from root
to src/main.
Closes #18436