feat: filterable class scanning of JAR #19299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change improves optimization of class scanning of `VaadinServletContextInitializer` by reading optional configuration file within a JAR dependency. Configuration file is a regular properties file that can contain `vaadin.allowed-packages` or `vaadin.blocked-packages` to exclude/include packages being scanned by `VaadinServletContextInitializer`. Package exclusion/inclusion effects only classes in the JAR/module where `META-INF/VAADIN/package.properties` is located at. Notice that this is only affecting the performance of the class scanning of Vaadin specific annotations and types and this feature is not meant to be used for excluding packages from the whole application. E.g. excluding `VaadinServiceInitListener` in a Spring application is not stopping Spring and Vaadin initializing it anyway, although some time-consuming actions like `DevModeServletContextListener` would still exclude it for optimization. Fixes: #19117
mcollovati
reviewed
May 3, 2024
vaadin-spring/src/main/java/com/vaadin/flow/spring/io/FilterableResourceResolver.java
Outdated
Show resolved
Hide resolved
flow-tests/vaadin-spring-tests/test-spring-filter-packages/lib-exclude/pom.xml
Outdated
Show resolved
Hide resolved
vaadin-spring/src/main/java/com/vaadin/flow/spring/io/FilterableResourceResolver.java
Outdated
Show resolved
Hide resolved
vaadin-spring/src/main/java/com/vaadin/flow/spring/io/FilterableResourceResolver.java
Show resolved
Hide resolved
vaadin-spring/src/main/java/com/vaadin/flow/spring/io/FilterableResourceResolver.java
Outdated
Show resolved
Hide resolved
|
mcollovati
approved these changes
May 6, 2024
|
This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves optimization of class scanning of
VaadinServletContextInitializerby reading optional configuration file within a JAR dependency. Configuration file is a regular properties file that can containvaadin.allowed-packagesorvaadin.blocked-packagesto exclude/include packages being scanned byVaadinServletContextInitializer. Package exclusion/inclusion effects only classes in the JAR/module whereMETA-INF/VAADIN/package.propertiesis located at.Notice that this is only affecting the performance of the class scanning of Vaadin specific annotations and types and this feature is not meant to be used for excluding packages from the whole application. E.g. excluding
VaadinServiceInitListenerin a Spring application is not stopping Spring and Vaadin initializing it anyway, although some time-consuming actions likeDevModeServletContextListenerwould still exclude it for optimization.Fixes: #19117