Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add HasLabelAsText interface to NativeButtonElement #19312

Merged
merged 5 commits into from
May 7, 2024

Conversation

joelpop
Copy link
Contributor

@joelpop joelpop commented May 6, 2024

Description

Elements having their labels in their text (such as buttons) must implement a new, method-less interface HasLabelAsText in their element tester (such as NativeButtonElement for the NativeButton component and ButtonElement for the Button component) in order for the withCaption[Containing] selectors to work for them.

Related Flow change for vaadin/testbench#1183

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@CLAassistant
Copy link

CLAassistant commented May 6, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@joelpop joelpop self-assigned this May 6, 2024
Copy link

github-actions bot commented May 6, 2024

Test Results

1 101 files  ± 0  1 101 suites  ±0   1h 22m 3s ⏱️ +25s
7 004 tests ± 0  6 955 ✅ ± 0  49 💤 ±0  0 ❌ ±0 
7 347 runs   - 30  7 288 ✅  - 28  59 💤  - 2  0 ❌ ±0 

Results for commit e8f1f64. ± Comparison against base commit f046a79.

♻️ This comment has been updated with latest results.

mcollovati
mcollovati previously approved these changes May 6, 2024
Copy link
Collaborator

@mcollovati mcollovati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs formatting. Other than that LGTM

Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
37 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@joelpop joelpop requested a review from mcollovati May 6, 2024 17:23
@mcollovati mcollovati changed the title Added HasLabelAsText interface to NativeButtonElement. feat: Added HasLabelAsText interface to NativeButtonElement. May 7, 2024
@mcollovati mcollovati enabled auto-merge (squash) May 7, 2024 05:49
@mcollovati mcollovati changed the title feat: Added HasLabelAsText interface to NativeButtonElement. feat: Add HasLabelAsText interface to NativeButtonElement May 7, 2024
@mcollovati mcollovati merged commit fe30566 into main May 7, 2024
42 of 46 checks passed
@mcollovati mcollovati deleted the test/testbench-e2e-withcaption-support branch May 7, 2024 07:21
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version.

vaadin-bot added a commit that referenced this pull request Jun 12, 2024
…#19566)

Co-authored-by: Joel Robertson <62086947+joelpop@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants