-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add HasLabelAsText interface to NativeButtonElement #19312
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs formatting. Other than that LGTM
…upport' into test/testbench-e2e-withcaption-support
Quality Gate passedIssues Measures |
This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version. |
Description
Elements having their labels in their text (such as buttons) must implement a new, method-less interface
HasLabelAsText
in their element tester (such asNativeButtonElement
for theNativeButton
component andButtonElement
for theButton
component) in order for thewithCaption[Containing]
selectors to work for them.Related Flow change for vaadin/testbench#1183
Type of change
Checklist
Additional for
Feature
type of change