feat: Flow components as children for ReactAdapterComponent #19434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for having Flow Components as children in a ReactAdapoterComponent Fixes #19379
knoobie
reviewed
May 23, 2024
flow-react/src/main/java/com/vaadin/flow/component/react/ReactAdapterComponent.java
Outdated
Show resolved
Hide resolved
Legioth
reviewed
May 24, 2024
Legioth
reviewed
May 24, 2024
Review fixes. Cleanup. Expand test.
tltv
previously approved these changes
May 30, 2024
platosha
requested changes
Jun 3, 2024
| @@ -118,6 +129,10 @@ export abstract class ReactAdapterElement extends HTMLElement { | |||
| this.#maybeRenderRoot(); | |||
| } | |||
|
|
|||
| public addReadyCallback(id: string, readyCallback: ReadyCallbackFunction) { | |||
There was a problem hiding this comment.
Missing JSdoc on the public method. Should this be marked as internal in JSdoc, perhaps?
platosha
approved these changes
Jun 3, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for having Flow Components
as children in a ReactAdapoterComponent
Fixes #19379