Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ValueContext.getBinder() #19487

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

tepi
Copy link
Contributor

@tepi tepi commented May 30, 2024

original authors: @archiecobbs and @mstahv

Minor fixes to contribution PR: #19131

Copy link

sonarcloud bot commented May 30, 2024

Quality Gate Passed Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Test Results

1 102 files  ±0  1 102 suites  ±0   1h 21m 3s ⏱️ + 3m 28s
7 048 tests +1  6 999 ✅ +1  49 💤 ±0  0 ❌ ±0 
7 380 runs  +8  7 321 ✅ +8  59 💤 ±0  0 ❌ ±0 

Results for commit d746a50. ± Comparison against base commit 00dd9ef.

Copy link
Contributor

@AlainaFaisal AlainaFaisal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic seems to be sound and the tests are also passing correcty.

@AlainaFaisal AlainaFaisal merged commit 90b3885 into main Jun 3, 2024
26 checks passed
@AlainaFaisal AlainaFaisal deleted the feat/valuecontext-binder-access branch June 3, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants