Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Binder record support #19806

Merged
merged 8 commits into from
Aug 23, 2024
Merged

feat: Binder record support #19806

merged 8 commits into from
Aug 23, 2024

Conversation

tepi
Copy link
Contributor

@tepi tepi commented Aug 20, 2024

Adds record support for Binder.

#17947

@tepi tepi marked this pull request as draft August 20, 2024 12:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 20, 2024 •
edited
Loading

Test Results

1 132 files  ± 0  1 132 suites  ±0   1h 29m 5s ⏱️ - 1m 12s
7 353 tests + 1  7 303 ✅ + 1  50 💤 ±0  0 ❌ ±0 
7 701 runs  +11  7 641 ✅ +11  60 💤 ±0  0 ❌ ±0 

Results for commit d99d2f8. ± Comparison against base commit b4297f3.

♻️ This comment has been updated with latest results.

@tepi tepi marked this pull request as ready for review August 21, 2024 07:22
@mshabarov mshabarov self-requested a review August 22, 2024 07:12
mshabarov
mshabarov requested changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@mshabarov mshabarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, but overall looks good to me.

Tested basic functionality for write/read records, hasChanges, validation and conversion, works as expected.

flow-data/src/main/java/com/vaadin/flow/data/binder/Binder.java Show resolved Hide resolved
flow-data/src/main/java/com/vaadin/flow/data/binder/Binder.java Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 22, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mshabarov mshabarov merged commit 9bc30b5 into main Aug 23, 2024
25 of 26 checks passed
@mshabarov mshabarov deleted the feat/binder-record-support branch August 23, 2024 05:47
@tepi tepi mentioned this pull request Aug 27, 2024
Closed
@mshabarov mshabarov mentioned this pull request Sep 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knoobie knoobie knoobie left review comments

@mshabarov mshabarov mshabarov approved these changes

Assignees
No one assigned
Labels
+0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tepi @knoobie @mshabarov @vaadin-bot