Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: client navigation for server layout #19898

Merged
merged 2 commits into from
Sep 6, 2024
Merged

fix: client navigation for server layout #19898

merged 2 commits into from
Sep 6, 2024

Conversation

caalador
Copy link
Contributor

@caalador caalador commented Sep 5, 2024

Fixes issue where client view with
server side layout is not rendered.
Better error messages.

Fixes vaadin/start#3169
fixes #19895

Make the faulty classes easier to spot.
Copy link

sonarcloud bot commented Sep 5, 2024

Copy link

github-actions bot commented Sep 5, 2024

Test Results

1 135 files  ± 0  1 135 suites  ±0   1h 26m 42s ⏱️ - 1m 42s
7 389 tests + 1  7 339 ✅ + 1  50 💤 ±0  0 ❌ ±0 
7 721 runs   - 34  7 661 ✅  - 34  60 💤 ±0  0 ❌ ±0 

Results for commit 60942bd. ± Comparison against base commit 4363bbf.

♻️ This comment has been updated with latest results.

@ZheSun88 ZheSun88 enabled auto-merge (squash) September 6, 2024 06:09
@ZheSun88 ZheSun88 enabled auto-merge (squash) September 6, 2024 06:09
@ZheSun88 ZheSun88 merged commit 9e66a44 into main Sep 6, 2024
42 checks passed
@ZheSun88 ZheSun88 deleted the fix/dx-fixes branch September 6, 2024 06:24
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha16 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PiT 24.5: There is content generated in start that it's not visible
4 participants