fix: wait for output reading to complete before parsing version #19921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NodeInstall.getVersion currently does not block waiting for STDOUT and STDERR to be read completely. This causes random failure during node installation because of forcing an empty version. This change waits for future to complete before parsing the version value.
|
Should fix random failures on "Slow tests" validation |
tltv
reviewed
Sep 10, 2024
flow-server/src/main/java/com/vaadin/flow/server/frontend/installer/NodeInstaller.java
Outdated
Show resolved
Hide resolved
|
tltv
approved these changes
Sep 11, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
NodeInstall.getVersion currently does not block waiting for STDOUT and STDERR to be read completely. This causes random failure during node installation because of forcing an empty version. This change waits for future to complete before parsing the version value.
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
NodeInstall.getVersion currently does not block waiting for STDOUT and STDERR to be read completely. This causes random failure during node installation because of forcing an empty version. This change waits for future to complete before parsing the version value.
vaadin-bot
added a commit
that referenced
this pull request
Sep 11, 2024
…) (#19930) NodeInstall.getVersion currently does not block waiting for STDOUT and STDERR to be read completely. This causes random failure during node installation because of forcing an empty version. This change waits for future to complete before parsing the version value. Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot
added a commit
that referenced
this pull request
Sep 11, 2024
…) (#19931) NodeInstall.getVersion currently does not block waiting for STDOUT and STDERR to be read completely. This causes random failure during node installation because of forcing an empty version. This change waits for future to complete before parsing the version value. Co-authored-by: Marco Collovati <marco@vaadin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeInstall.getVersion currently does not block waiting for STDOUT and STDERR to be read completely. This causes random failure during node installation because of forcing an empty version.
This change waits for future to complete before parsing the version value.