Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: show warning when LC is missing in a DAU build (#20036) (CP: 24.5) #20039

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

* chore: show warning when LC is missing in a DAU build

In a DAU build, checks if license-checker will be present at runtime and
prints a warning message with instructions to fix the configuration if
it the dependency is missing.

* Apply suggestions from code review

Co-authored-by: Tomi Virtanen <tltv@vaadin.com>

---------

Co-authored-by: Tomi Virtanen <tltv@vaadin.com>
@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot vaadin-bot enabled auto-merge (squash) September 24, 2024 09:09
Copy link

sonarcloud bot commented Sep 24, 2024

Copy link

Test Results

1 137 files  ±0  1 137 suites  ±0   1h 9m 10s ⏱️ +40s
7 399 tests ±0  7 349 ✅ ±0  50 💤 ±0  0 ❌ ±0 
7 763 runs   - 1  7 706 ✅ +2  57 💤  - 3  0 ❌ ±0 

Results for commit b7ba64f. ± Comparison against base commit c01cdbb.

@vaadin-bot vaadin-bot merged commit d641601 into 24.5 Sep 24, 2024
25 of 26 checks passed
@vaadin-bot vaadin-bot deleted the cherry-pick-20036-to-24.5-1727168528835 branch September 24, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants