Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update title after navigation (#20047) (CP: 24.5) #20060

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

Update the page title after
navigation has ended to
not have the wrong title in
history.

Fixes #19868
@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot vaadin-bot enabled auto-merge (squash) September 26, 2024 07:25
Copy link

sonarcloud bot commented Sep 26, 2024

Copy link

Test Results

1 137 files  ±0  1 137 suites  ±0   1h 8m 8s ⏱️ - 1m 44s
7 399 tests ±0  7 349 ✅ ±0  50 💤 ±0  0 ❌ ±0 
7 766 runs   - 2  7 706 ✅  - 2  60 💤 ±0  0 ❌ ±0 

Results for commit ad6cc4e. ± Comparison against base commit c5ef12d.

@vaadin-bot vaadin-bot merged commit e50f188 into 24.5 Sep 26, 2024
25 of 26 checks passed
@vaadin-bot vaadin-bot deleted the cherry-pick-20047-to-24.5-1727335244433 branch September 26, 2024 07:36
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 24.5.0.beta4 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants