Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add nodeVersion in gradle plugin settings (#20059) (CP: 24.4) #20090

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

Prior to this fix, the settings declared in Gradle were not being passed to the plugin. For example, changing the nodeVersion in build.gradle did not update the actual nodeVersion used.
Copy link

Test Results

1 111 files  ± 0  1 111 suites  ±0   1h 8m 31s ⏱️ + 1m 41s
7 058 tests ± 0  7 009 ✅ ± 0  49 💤 ±0  0 ❌ ±0 
7 394 runs  +15  7 333 ✅ +15  61 💤 ±0  0 ❌ ±0 

Results for commit 4baef87. ± Comparison against base commit 9978b1b.

Copy link

sonarcloud bot commented Sep 27, 2024

@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot vaadin-bot merged commit 4e2d9ec into 24.4 Sep 27, 2024
25 of 26 checks passed
@vaadin-bot vaadin-bot deleted the cherry-pick-20059-to-24.4-1727444036212 branch September 27, 2024 14:30
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 24.4.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants