Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: consider layout prefixes when checkin for route and alias paths #20126

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix: consider layout prefixes when checkin for route and alias paths #20126

merged 1 commit into from
Oct 3, 2024

Conversation

mcollovati
Copy link
Collaborator

Fixes #20124

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 2, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Test Results

1 139 files  ± 0  1 139 suites  ±0   1h 11m 17s ⏱️ +24s
7 417 tests + 3  7 367 ✅ + 4  50 💤 ±0  0 ❌ ±0 
7 781 runs  +21  7 721 ✅ +22  60 💤 ±0  0 ❌ ±0 

Results for commit 2e84651. ± Comparison against base commit 95db483.

@mcollovati mcollovati merged commit d475155 into main Oct 3, 2024
26 checks passed
@mcollovati mcollovati deleted the issues/20124-fix_path_check branch October 3, 2024 05:01
vaadin-bot pushed a commit that referenced this pull request Oct 3, 2024
@mcollovati @vaadin-bot
fix: consider layout prefixes when checking for route and alias paths (…
d55bf34 
…#20126)

Fixes #20124
vaadin-bot pushed a commit that referenced this pull request Oct 3, 2024
@mcollovati @vaadin-bot
fix: consider layout prefixes when checking for route and alias paths (…
e228e2c 
…#20126)

Fixes #20124
vaadin-bot pushed a commit that referenced this pull request Oct 3, 2024
@mcollovati @vaadin-bot
fix: consider layout prefixes when checking for route and alias paths (…
0a262ad 
…#20126)

Fixes #20124
vaadin-bot pushed a commit that referenced this pull request Oct 3, 2024
@mcollovati @vaadin-bot
fix: consider layout prefixes when checking for route and alias paths (…
ee13bd3 
…#20126)

Fixes #20124
vaadin-bot added a commit that referenced this pull request Oct 3, 2024
@vaadin-bot @mcollovati
fix: consider layout prefixes when checking for route and alias paths (…
c7c63a8 
…#20126) (#20128)

Fixes #20124

Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot added a commit that referenced this pull request Oct 3, 2024
@vaadin-bot @mcollovati
fix: consider layout prefixes when checking for route and alias paths (…
522af70 
…#20126) (#20130)

Fixes #20124

Co-authored-by: Marco Collovati <marco@vaadin.com>
mcollovati pushed a commit that referenced this pull request Oct 3, 2024
@vaadin-bot
fix: consider layout prefixes when checking for route and alias paths (…
46043b5 
…#20126) (#20127)

Fixes #20124
vaadin-bot added a commit that referenced this pull request Oct 3, 2024
@vaadin-bot @mcollovati
fix: consider layout prefixes when checkin for route and alias paths (#…
fd7d674 
…20126) (CP: 23.5) (#20129)

* fix: consider layout prefixes when checking for route and alias paths (#20126)

Fixes #20124

* fix test

---------

Co-authored-by: Marco Collovati <marco@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caalador caalador caalador approved these changes

Assignees
No one assigned
Labels
cherry-picked-23.5 cherry-picked-24.3 cherry-picked-24.4 cherry-picked-24.5 target/23.5 target/24.3 target/24.4 target/24.5 +0.0.1
Projects
Vaadin Flow ongoing work (Vaadin 10+)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InvalidRouteConfigurationException is incorrectly reported
3 participants
@mcollovati @caalador @vaadin-bot