Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add MenuConfiguration (#20138) (CP: 24.5) #20146

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

* feat: add MenuConfiguration

New public API for building application menu: adds `MenuConfiguration`, `MenuOptions` and `MenuOption` where `MenuConfiguration` is the main entry point to access menu data to build main menu.

Fixes: #20063

* chore: renamed classes and removed MenuOptions

Renamed MenuOption to MenuEntry.

* chore: updated javadocs

* chore: moved MenuRegistry to internal package

Removed Serializable from MenuConfiguration.

* chore: added javadoc and deprecated MenuData constructor

* chore: use new constructor

* chore: make MenuConfiguration final
Copy link

sonarcloud bot commented Oct 4, 2024

Copy link

github-actions bot commented Oct 4, 2024

Test Results

1 140 files  +1  1 140 suites  +1   1h 12m 33s ⏱️ +45s
7 416 tests +3  7 366 ✅ +3  50 💤 ±0  0 ❌ ±0 
7 783 runs  +3  7 723 ✅ +3  60 💤 ±0  0 ❌ ±0 

Results for commit 86b20c7. ± Comparison against base commit a310a43.

@mshabarov mshabarov merged commit f98f828 into 24.5 Oct 4, 2024
26 checks passed
@mshabarov mshabarov deleted the cherry-pick-20138-to-24.5-1728041514078 branch October 4, 2024 12:21
@mshabarov mshabarov changed the title feat: add MenuConfiguration (#20138) (CP: 24.5) feat!: add MenuConfiguration (#20138) (CP: 24.5) Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants