Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for Grid selection and column configuration #2812

Merged
merged 8 commits into from
Nov 2, 2017

Conversation

ahie
Copy link
Contributor

@ahie ahie commented Oct 31, 2017

This change is Reviewable

@gilberto-torrezan
Copy link
Contributor

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


flow-documentation/flow-components/tutorial-flow-grid.asciidoc, line 95 at r1 (raw file):

The current selection can be obtained from the [classname]#Grid# by
[methodname]#getSelectedItems()#, and the returned [classname]#Set# contains either

Those [methodname] and [classname] don't seem to affect the rendering in any way (at least I couldn't see any difference at https://github.com/vaadin/flow/blob/grid-documentation/flow-documentation/flow-components/tutorial-flow-grid.asciidoc ). Is this a syntax copied from the old documentation?


Comments from Reviewable

@ahie
Copy link
Contributor Author

ahie commented Nov 2, 2017

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


flow-documentation/flow-components/tutorial-flow-grid.asciidoc, line 95 at r1 (raw file):

Previously, gilberto-torrezan (Gilberto Torrezan) wrote…

Those [methodname] and [classname] don't seem to affect the rendering in any way (at least I couldn't see any difference at https://github.com/vaadin/flow/blob/grid-documentation/flow-documentation/flow-components/tutorial-flow-grid.asciidoc ). Is this a syntax copied from the old documentation?

Changed these to use backticks.


Comments from Reviewable

@gilberto-torrezan
Copy link
Contributor

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


flow-documentation/flow-components/tutorial-flow-grid.asciidoc, line 95 at r1 (raw file):

Previously, ahie (Aleksi Hietanen) wrote…

Changed these to use backticks.

Did you push it? I don't see any changes.


Comments from Reviewable

@gilberto-torrezan
Copy link
Contributor

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@ahie ahie merged commit 7dd818d into master Nov 2, 2017
@ahie ahie deleted the grid-documentation branch November 2, 2017 11:14
@denis-anisimov denis-anisimov added this to the 1.0.0.alpha9 milestone Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants