-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix single selection on the same row, item updates #2877
Conversation
Reviewed 2 of 2 files at r1. flow-components-parent/demo-flow-components/src/test/java/com/vaadin/flow/demo/views/GridViewIT.java, line 112 at r1 (raw file):
Is this reliable? Comments from Reviewable |
Review status: all files reviewed at latest revision, 1 unresolved discussion. flow-components-parent/demo-flow-components/src/test/java/com/vaadin/flow/demo/views/GridViewIT.java, line 112 at r1 (raw file): Previously, gilberto-torrezan (Gilberto Torrezan) wrote…
Kirill answered with a code that inspects the error messages in the client console. That is more reliable, and could be exported as an Util method for other tests that need the same functionality. Comments from Reviewable |
Review status: 1 of 3 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed. flow-components-parent/demo-flow-components/src/test/java/com/vaadin/flow/demo/views/GridViewIT.java, line 112 at r1 (raw file): Previously, gilberto-torrezan (Gilberto Torrezan) wrote…
Done. Comments from Reviewable |
Reviewed 2 of 2 files at r2. Comments from Reviewable |
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed. flow-components-parent/demo-flow-components/src/test/java/com/vaadin/flow/demo/views/GridViewIT.java, line 112 at r2 (raw file):
The problem in CI might be that the code also gets all warnings, and you just want errors. Comments from Reviewable |
…nto grid-selection-fix
Reviewed 2 of 2 files at r3. Comments from Reviewable |
Fixes #2874
Fixes #2872
This change is