Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UA compatible meta tag in bootstrap handler #2893

Merged
merged 2 commits into from
Nov 14, 2017

Conversation

denis-anisimov
Copy link
Contributor

@denis-anisimov denis-anisimov commented Nov 10, 2017

Fix for #2477


This change is Reviewable

@torok-peter
Copy link
Contributor

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


flow-server/src/test/java/com/vaadin/server/BootstrapHandlerTest.java, line 162 at r1 (raw file):

    @Test
    public void headHasmetaTags() throws Exception {

headHasMetaTags ?


Comments from Reviewable

@denis-anisimov
Copy link
Contributor Author

Review status: 1 of 2 files reviewed at latest revision, 1 unresolved discussion.


flow-server/src/test/java/com/vaadin/server/BootstrapHandlerTest.java, line 162 at r1 (raw file):

Previously, torok-peter (Péter Török) wrote…

headHasMetaTags ?

Done.


Comments from Reviewable

@torok-peter
Copy link
Contributor

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@denis-anisimov
Copy link
Contributor Author

Reviewed 2 of 2 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants