Use the new router by default

[caalador]

This change is 

[CLAassistant]

All committers have signed the CLA.

[denis-anisimov]

Reviewed 65 of 67 files at r1, 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 6 unresolved discussions.

---

flow-server/src/test/java/com/vaadin/server/MockVaadinServletService.java, line 53 at r2 (raw file):

e.printStackTrace();

Are you sure that it shouldn't throw a runtime exception ?

---

flow-test-util/src/main/java/com/vaadin/flow/testutil/AbstractParallelTestBenchTest.java, line 70 at r2 (raw file):

public void setup() throws Exception {

Quoted 5 lines of code…

> if(USE_HUB) { > setDesiredCapabilities(Browser.CHROME.getDesiredCapabilities()); > } > super.setup(); > }

What's the need for those changes ?

---

flow-test-util/src/main/java/com/vaadin/flow/testutil/AbstractParallelTestBenchTest.java, line 116 at r2 (raw file):

@OverRide

Quoted 5 lines of code…

> protected Browser getRunLocallyBrowser() { > if (USE_HUB) { > return null; > } > return Browser.CHROME;

What's the need for those changes ?

---

flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/servlet/ApplicationRunnerServlet.java, line 286 at r2 (raw file):

e.printStackTrace();

Throw a runtime exception ?

---

flow-tests/test-subcontext/src/main/java/com/vaadin/flow/contexttest/ui/DependencyUI.java, line 59 at r2 (raw file):

// Don't try to use router just display the

display what ?

---

flow-tests/test-subcontext/src/main/java/com/vaadin/flow/contexttest/ui/DependencyUI.java, line 72 at r2 (raw file):

e.printStackTrace();

Throw a runtime exception ?

---

Comments from Reviewable

[caalador]

Review status: 43 of 75 files reviewed at latest revision, 6 unresolved discussions.

---

flow-test-util/src/main/java/com/vaadin/flow/testutil/AbstractParallelTestBenchTest.java, line 70 at r2 (raw file):

Previously, denis-anisimov (Denis) wrote…

public void setup() throws Exception {
if(USE_HUB) {
setDesiredCapabilities(Browser.CHROME.getDesiredCapabilities());
}
super.setup();
}

What's the need for those changes ?

For some reason with merge from master TB started to default to FireFox and not read the BrowserConfiguration.

---

flow-test-util/src/main/java/com/vaadin/flow/testutil/AbstractParallelTestBenchTest.java, line 116 at r2 (raw file):

Previously, denis-anisimov (Denis) wrote…

@OverRide
protected Browser getRunLocallyBrowser() {
if (USE_HUB) {
return null;
}
return Browser.CHROME;

What's the need for those changes ?

Local browser was not gotten from the same place as before and tests were trying to run only on the test hub target localhost:4444/...

---

flow-tests/test-subcontext/src/main/java/com/vaadin/flow/contexttest/ui/DependencyUI.java, line 59 at r2 (raw file):

Previously, denis-anisimov (Denis) wrote…

// Don't try to use router just display the

display what ?

it was supposed to end with UI. Removed due to small change to Router.

---

flow-tests/test-subcontext/src/main/java/com/vaadin/flow/contexttest/ui/DependencyUI.java, line 72 at r2 (raw file):

Previously, denis-anisimov (Denis) wrote…

e.printStackTrace();

Throw a runtime exception ?

This is removed. Updated router.

---

flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/servlet/ApplicationRunnerServlet.java, line 286 at r2 (raw file):

Previously, denis-anisimov (Denis) wrote…

e.printStackTrace();

Throw a runtime exception ?

This is removed. Updated router and moved pure UI tests to own module.

---

Comments from Reviewable

[denis-anisimov]

Reviewed 56 of 56 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

Comments from Reviewable

[caalador]

Review status: 73 of 76 files reviewed at latest revision, 2 unresolved discussions.

---

flow-server/src/test/java/com/vaadin/server/MockVaadinServletService.java, line 53 at r2 (raw file):

Previously, denis-anisimov (Denis) wrote…

e.printStackTrace();

Are you sure that it shouldn't throw a runtime exception ?

Done.

---

Comments from Reviewable

[denis-anisimov]

Reviewed 1 of 1 files at r4, 2 of 2 files at r5.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable