Don't send model properties to the server if they are not updatable

[denis-anisimov]

Fix for #3425

---

This change is 

[SomeoneToIgnore]

Reviewed 2 of 6 files at r1, 11 of 12 files at r2, 6 of 6 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/PolymerTemplate.java, line 209 at r3 (raw file):

        List<String> propertyNames = removeSimpleProperties();

        // This has to be executed BEFORE model population to be able to know

Is it possible to unite this and the next JS calls into one method call?
So you don't have to care about the order of the calls?

---

Comments from Reviewable

[denis-anisimov]

Review status: 13 of 17 files reviewed at latest revision, 1 unresolved discussion.

---

flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/PolymerTemplate.java, line 209 at r3 (raw file):

Previously, SomeoneToIgnore (Kirill Bulatov) wrote…

Is it possible to unite this and the next JS calls into one method call?
So you don't have to care about the order of the calls?

Just let me know how.

---

Comments from Reviewable

[SomeoneToIgnore]

flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/PolymerTemplate.java, line 209 at r3 (raw file):

Previously, denis-anisimov (Denis) wrote…

Just let me know how.

To me it is.

---

Comments from Reviewable

[denis-anisimov]

Review status: 13 of 17 files reviewed at latest revision, all discussions resolved.

---

flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/PolymerTemplate.java, line 209 at r3 (raw file):

Previously, SomeoneToIgnore (Kirill Bulatov) wrote…

To me it is.

Just let me know how.

---

Comments from Reviewable

[SomeoneToIgnore]

flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/PolymerTemplate.java, line 209 at r3 (raw file):

Previously, denis-anisimov (Denis) wrote…

Just let me know how.

Well, can you unite two methods into one, get three parameters in it and do all the required stuff in the order required there, can't you?

---

Comments from Reviewable

[denis-anisimov]

Review status: 13 of 17 files reviewed at latest revision, all discussions resolved.

---

flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/PolymerTemplate.java, line 209 at r3 (raw file):

Previously, SomeoneToIgnore (Kirill Bulatov) wrote…

Well, can you unite two methods into one, get three parameters in it and do all the required stuff in the order required there, can't you?

Ah, sorry. Wrong place of the code. Thought that this is client side code..........
(I'm so tired from this crappy solutions).

Well......
Has sense.
The result will be most likely two more days of fixing tests: now: there are two independent public methods on the client side which are tested via the GWT tests.
In the result there will be one method which will needs tests adoption.

Let's say : I don't want to fix more GWT tests in this patch anymore.
I spent more than 3 days on this shit.
I will create a ticket for this improvement.

---

Comments from Reviewable

[denis-anisimov]

Review status: 13 of 17 files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/PolymerTemplate.java, line 209 at r3 (raw file):

Previously, denis-anisimov (Denis) wrote…

Ah, sorry. Wrong place of the code. Thought that this is client side code..........
(I'm so tired from this crappy solutions).

Well......
Has sense.
The result will be most likely two more days of fixing tests: now: there are two independent public methods on the client side which are tested via the GWT tests.
In the result there will be one method which will needs tests adoption.

Let's say : I don't want to fix more GWT tests in this patch anymore.
I spent more than 3 days on this shit.
I will create a ticket for this improvement.

#3502

---

Comments from Reviewable

[SomeoneToIgnore]

Review status: 13 of 17 files reviewed at latest revision, 1 unresolved discussion.

---

flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/PolymerTemplate.java, line 209 at r3 (raw file):

Previously, denis-anisimov (Denis) wrote…

#3502

Oh, I see, disregard the comment then :)
Thanks.

---

Comments from Reviewable

[vaadin-bot]

SonarQube analysis reported 5 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

1. ExecuteJavaScriptProcessor.java#L177: Remove this unused private "handleRemoveExistingNode" method.
2. ExecuteJavaScriptProcessor.java#L186: Remove this unused private "getAppId" method.
3. StateNode.java#L247: Suspicious comparison of Boolean references in com.vaadin.client.flow.StateNode.lambda$setDomNode$3(Function)
4. SimpleElementBindingStrategy.java#: This file has 842 lines, which is greater than 750 authorized. Split it into smaller files.
5. SimpleElementBindingStrategy.java#L777: Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed.

[SomeoneToIgnore]

Reviewed 6 of 6 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable