Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning should be printed when no NoTheme annotation is present #3512

Closed
wants to merge 1 commit into from

Conversation

caalador
Copy link
Contributor

@caalador caalador commented Feb 8, 2018

This change is Reviewable

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 23 issues

  • CRITICAL 1 critical
  • MAJOR 2 major
  • MINOR 20 minor

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL UIInternals.java#L541: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  2. MAJOR UIInternals.java#L381: This block of commented-out lines of code should be removed. rule
  3. MAJOR UIInternals.java#L505: Refactor this method to reduce its Cognitive Complexity from 19 to the 15 allowed. rule
  4. MINOR UIInternals.java#L152: Remove this use of "View"; it is deprecated. rule
  5. MINOR UIInternals.java#L407: This call to "remove()" may be a performance hot spot if the collection is large. rule
  6. MINOR UIInternals.java#L505: Remove this use of "View"; it is deprecated. rule
  7. MINOR UIInternals.java#L506: Remove this use of "HasChildView"; it is deprecated. rule
  8. MINOR UIInternals.java#L516: Remove this use of "HasChildView"; it is deprecated. rule
  9. MINOR UIInternals.java#L516: Remove this use of "View"; it is deprecated. rule
  10. MINOR UIInternals.java#L518: Remove this use of "View"; it is deprecated. rule

@SomeoneToIgnore
Copy link
Contributor

Sorry, have noticed this PR later then #3515
Will close this one.

@SomeoneToIgnore SomeoneToIgnore deleted the issues/faulty_check branch February 8, 2018 15:18
@gilberto-torrezan gilberto-torrezan added this to the Abandoned milestone Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants