Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove error message when the field becomes valid #3552

Merged
merged 1 commit into from
Feb 14, 2018

Conversation

denis-anisimov
Copy link
Contributor

@denis-anisimov denis-anisimov commented Feb 14, 2018

Fix for #3439


This change is Reviewable

@caalador
Copy link
Contributor

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 53 issues

  • CRITICAL 3 critical
  • MAJOR 19 major
  • MINOR 31 minor

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL Binder.java#L1299: Move this constructor to comply with Java Code Conventions. rule
  2. CRITICAL Binder.java#L2418: Either log or rethrow this exception. rule
  3. CRITICAL Binder.java#L2479: Either log or rethrow this exception. rule
  4. MAJOR Binder.java#: This file has 1,017 lines, which is greater than 750 authorized. Split it into smaller files. rule
  5. MAJOR Binder.java#L116: Remove usage of generic wildcard type. rule
  6. MAJOR Binder.java#L116: Remove usage of generic wildcard type. rule
  7. MAJOR Binder.java#L190: Remove usage of generic wildcard type. rule
  8. MAJOR Binder.java#L190: Remove usage of generic wildcard type. rule
  9. MAJOR Binder.java#L761: Define and throw a dedicated exception instead of using a generic one. rule
  10. MAJOR Binder.java#L802: Prefix this call to "withValidator" with "super.". rule

@denis-anisimov denis-anisimov merged commit d9fdc56 into master Feb 14, 2018
@denis-anisimov denis-anisimov deleted the 3439-binder-error-message branch February 14, 2018 07:40
@SomeoneToIgnore SomeoneToIgnore added this to the 1.0.0.alpha21 milestone Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants