Add methods to control validation #8094
Conversation
- Enable / disable all validators on Binder level - Enable / disable validators on Binding level - add writeBeanAsDraft(bean,boolean) for writing draft bean with validators disabled Fixes: #5030
| @@ -849,6 +866,7 @@ protected BindingBuilderImpl(Binder<BEAN> binder, | |||
| Binding binding = ((BindingBuilder) finalBinding).bind(getter, | |||
There was a problem hiding this comment.
| * | ||
| * @param validatorsDisabled A boolean value | ||
| */ | ||
| public void setValidatorsDisabled(boolean validatorsDisabled); |
There was a problem hiding this comment.
| * | ||
| * @return A boolean value | ||
| */ | ||
| public boolean isValidatorsDisabled(); |
There was a problem hiding this comment.
|
SonarQube analysis reported 4 issues
Watch the comments in this conversation to review them. 1 extra issueNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r4.
Reviewable status: 3 unresolved discussions, 0 of 1 LGTMs obtained (waiting on @TatuLund)
flow-data/src/main/java/com/vaadin/flow/data/binder/Binder.java, line 1892 at r4 (raw file):
disable all Validators during write
disable validators during write if true would be clearer as the current param description doesn't indicate value expectations.
There was a problem hiding this comment.
Dismissed @vaadin-bot from 3 discussions.
Reviewable status:complete! all discussions resolved, 1 of 1 LGTMs obtained
- Enable / disable all validators on Binder level - Enable / disable validators on Binding level - add writeBeanAsDraft(bean,boolean) for writing draft bean with validators disabled Fixes #5030
- Enable / disable all validators on Binder level - Enable / disable validators on Binding level - add writeBeanAsDraft(bean,boolean) for writing draft bean with validators disabled Fixes #5030
Fixes: #5030
This change is