Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regenerate file-router files when layouts changes #2796

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mcollovati
Copy link
Contributor

Description

The layouts file can be updated by Flow at runtime when an annotated layout class is modified and reloaded.
This change forces the Vite file-router plugin to regenerate files and trigger a fs-route-update to refresh the client configuration.

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

The layouts file can be updated by Flow at runtime when an annotated
layout class is modified and reloaded.
This change forces the Vite file-router plugin to regenerate files
and trigger a fs-route-update to refresh the client configuration.
@mcollovati mcollovati changed the title fix: regenerate file-routes files when layouts change fix: regenerate file-router files when layouts change Oct 4, 2024
@mcollovati mcollovati changed the title fix: regenerate file-router files when layouts change fix: regenerate file-router files when layouts changes Oct 4, 2024
Copy link

sonarcloud bot commented Oct 7, 2024

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.26%. Comparing base (ee782b2) to head (f434639).

Files with missing lines Patch % Lines
packages/ts/file-router/src/vite-plugin.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2796      +/-   ##
==========================================
- Coverage   92.29%   92.26%   -0.04%     
==========================================
  Files          81       81              
  Lines        2675     2676       +1     
  Branches      685      686       +1     
==========================================
  Hits         2469     2469              
- Misses        156      157       +1     
  Partials       50       50              
Flag Coverage Δ
unittests 92.26% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant