Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable chrome search engine selection #1818

Merged
merged 1 commit into from
Aug 23, 2024
Merged

fix: disable chrome search engine selection #1818

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion vaadin-testbench-shared/src/main/java/com/vaadin/testbench/parallel/setup/LocalDriver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,14 @@ static public WebDriver createDriver(
}
driver = new FirefoxDriver(options);
} else if (BrowserUtil.isChrome(desiredCapabilities)) {
ChromeOptions options = new ChromeOptions();
// Tells chrome not to show warning
// "You are using an unsupported command-line flag:
// --ignore-certifcate-errors".
// #14319
ChromeOptions options = new ChromeOptions();
options.addArguments("--test-type ");
// Disable search engine choice screen
options.addArguments("--disable-search-engine-choice-screen");
Copy link
Contributor Author

@sissbruecker sissbruecker Aug 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the search engine selection should be disabled for other types of tests too.

However for local tests it's problematic because it seems that you can't customize the Chrome options in your test code - the method here ignores just ignores the capabilities passed in, so even if you would try to add this argument in your test setup it doesn't work. For example, I tried to configure the argument in flow-components here, but the capabilities created from that are ignored.


if (Parameters.isHeadless()) {
options.addArguments("--headless=new");
Expand Down