Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: align checkValidity() behavior with text-field #4198

Closed
wants to merge 2 commits into from
Closed

fix: align checkValidity() behavior with text-field #4198

wants to merge 2 commits into from

Conversation

web-padawan
Copy link
Member

Description

  1. Updated to not mark vaadin-select as invalid when readonly is set
  2. Updated to reset invalid property when required is set to false
  3. Updated to not reset invalid property when required is not set

Fixes #4180

Type of change

  • Bugfix / refactor

@web-padawan web-padawan requested a review from vursen July 14, 2022 12:09
@sonarcloud
Copy link

sonarcloud bot commented Jul 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

This was referenced Jul 14, 2022
Merged
Merged
@web-padawan
Copy link
Member Author

Closing as #4200 and #4201 have been merged. The remaining change is now conflicting with the behavior introduced in #4201 - let's discuss #4170 and #4196 first before implementing this behavior in all the field components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vursen vursen Awaiting requested review from vursen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[select] Do not mark as invalid when readonly
1 participant
@web-padawan