-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(test): interop transport #1159
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1159 +/- ##
==========================================
- Coverage 84.53% 84.53% -0.01%
==========================================
Files 91 92 +1
Lines 15517 16403 +886
==========================================
+ Hits 13118 13866 +748
- Misses 2399 2537 +138 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed on discord, this is not the right solution.
The job now logs much more things and takes longer to run. It might be better to find a way to reduce the logs like it was before. it's taking 41 min to run now. Previously, it took 10 min.
This reverts commit 1577ddf.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We agreed to merge it and work on fixing the caching issue that is making the docker images to be built on every run.
We discussed this in the meeting. We'll go with this version for now to have the tests run. |
Free disk space before running the steps of interop's transport test.
The original job has enough space but in our repo it crashes midway due to missing disk space.