Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): interop transport #1159

Merged
merged 4 commits into from
Aug 2, 2024
Merged

fix(test): interop transport #1159

merged 4 commits into from
Aug 2, 2024

Conversation

AlejandroCabeza
Copy link
Collaborator

Free disk space before running the steps of interop's transport test.
The original job has enough space but in our repo it crashes midway due to missing disk space.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.53%. Comparing base (02c96fc) to head (fad535e).
Report is 38 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1159      +/-   ##
==========================================
- Coverage   84.53%   84.53%   -0.01%     
==========================================
  Files          91       92       +1     
  Lines       15517    16403     +886     
==========================================
+ Hits        13118    13866     +748     
- Misses       2399     2537     +138     

see 80 files with indirect coverage changes

Copy link
Collaborator

@kaiserd kaiserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

Copy link
Contributor

@diegomrsantos diegomrsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed on discord, this is not the right solution.

The job now logs much more things and takes longer to run. It might be better to find a way to reduce the logs like it was before. it's taking 41 min to run now. Previously, it took 10 min.

Copy link
Contributor

@diegomrsantos diegomrsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We agreed to merge it and work on fixing the caching issue that is making the docker images to be built on every run.

@kaiserd
Copy link
Collaborator

kaiserd commented Aug 2, 2024

We discussed this in the meeting. We'll go with this version for now to have the tests run.
Next step is establishing a cache for docker imgs to make the runs faster.

@kaiserd kaiserd merged commit fdae9e4 into master Aug 2, 2024
14 checks passed
@kaiserd kaiserd deleted the fix/interop-transport-test branch August 2, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

4 participants