feat(cardano): add support for CIP36 governance registration format #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielKerekes
approved these changes
Oct 3, 2022
davidmisiak
force-pushed
the
cardano-governance-cip36
branch
from
31e02d6
to
97f2289
Compare
davidmisiak
force-pushed
the
cardano-governance-cip36
branch
from
97f2289
to
6c2e34e
Compare
|
Merged in trezor#6735 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for CIP36 governance registration format. The corresponding firmware PR is here. Please see
cardanoSignTransaction.mdchanges for the new transaction items.I believe that the only breaking change is renaming these two items (so that it is clear that they serve also for other governance purposes, not only Catalyst):
catalystRegistrationParameterstogovernanceRegistrationParameters(inCardanoAuxiliaryData)catalystSignaturetogovernanceSignature(inCardanoAuxiliaryDataSupplement)TODO:
proportiontoweight