internal [SPM] Add logic to disable the feature before stopping it and enabling it before starting #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it before starting.
| @@ -1017,8 +1017,10 @@ def _get_installed_packages_except(self, package: Package) -> Dict[str, Package] | |||
|
|
|||
| def _stop_feature(self, package: Package): | |||
| self._systemctl_action(package, 'stop') | |||
| self._systemctl_action(package, 'disable') | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add logic to disable the feature before stopping and enabling it before starting in order to properly clean the
systemdsymlinks to avoid issues withdelayedattribute explained in theHow to verify itsection.How I did it
Add the
systemctl disable ...after thesystemctl stop...and thesystemctl enable ...before thesystemctl start ..for some feature.How to verify it
featureXsonic-package-manager repository <featureX> <URL>featureXversion 1.0.0 where thedelayedflag is equal tofalse(delayedflag means - the feature will be started right after the system boots or after thePortInitDoneevent)sonic-package-manager install featureX==1.0.0 -yconfig feature state featureX enabledfeatureXversion 1.0.1 where thedelayedflag is equal totruesonic-package-manager install featureX==1.0.1 -ymanifestfile to verify thedelayedfield valuesonic-package-manager show package manifest featureXconfig save -yrebootfeatureXis delayed on the system startPrevious command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)