This repository has been archived by the owner on Jun 25, 2023. It is now read-only.
Issue #189 Use static private network configuration to find routable host IP #192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of a private network with static IP, it is possible to extract the routable host IP from Vagrant's network config. Only if there is no static network config or the configuration is not complete (eg multiple private networks where none is explicitly selected via config.landrush.host_ip_address we move on and rely on the read_host_visible_ip_address capability. Currently this is still just based on uname,but will be hopefully shortly extended by @Werelds IP selection approach - see pull request #122