Skip to content
This repository has been archived by the owner on Jun 25, 2023. It is now read-only.

Issue #189 Use static private network configuration to find routable host IP #192

Merged
merged 1 commit into from
Jun 22, 2016

Conversation

hferentschik
Copy link
Contributor

@hferentschik hferentschik commented Jun 2, 2016

In the case of a private network with static IP, it is possible to extract the routable host IP from Vagrant's network config. Only if there is no static network config or the configuration is not complete (eg multiple private networks where none is explicitly selected via config.landrush.host_ip_address we move on and rely on the read_host_visible_ip_address capability. Currently this is still just based on uname,but will be hopefully shortly extended by @Werelds IP selection approach - see pull request #122

@hferentschik
Copy link
Contributor Author

@bexelbie WDYT?

@bexelbie
Copy link
Contributor

bexelbie commented Jun 6, 2016

If I am understanding #122, it will return this information. Why have a separate detection routine just for this one specific scenario?

@hferentschik
Copy link
Contributor Author

Why have a separate detection routine just for this one specific scenario?

Because for the case where the private network is defined statically, there is no need to go via the guest capabilities. This route seems safer to me. Once DHCP comes into play you need to contact the guest.

Also if the user defines multiple private network you might get into trouble with the NIC detection approach. Much easier to stick to the existing config and an already existing config option.

@hferentschik hferentschik changed the title Issue #189 Setup uses now private network static ip configuration (if… Issue #189 Use static private network configuration to find routable host IP Jun 9, 2016
…case of a single private network with static IP the default IP detection meachanism can be bypassed
@hferentschik hferentschik merged commit bc3e195 into vagrant-landrush:master Jun 22, 2016
@hferentschik hferentschik deleted the issue-189 branch October 6, 2016 10:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants