Fix Smile-SA#3205, remove type parameter in order to compatibility wi…

…th Elasticsearch 8
vahonc · Mar 26, 2024 · fda404f · fda404f
1 parent f5168a0
commit fda404f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/module-elasticsuite-core/Index/Bulk/BulkRequest.php b/src/module-elasticsuite-core/Index/Bulk/BulkRequest.php
@@ -55,7 +55,7 @@ public function getOperations()
      */
     public function addDocument(IndexInterface $index, $docId, array $data)
     {
-        $this->bulkData[] = ['index' => ['_index' => $index->getName(), /*'_type' => '_doc',*/ '_id' => $docId]];
+        $this->bulkData[] = ['index' => ['_index' => $index->getName(), '_id' => $docId]];
         $this->bulkData[] = $data;
 
         return $this;
@@ -78,7 +78,7 @@ public function addDocuments(IndexInterface $index, array $data)
      */
     public function deleteDocument(IndexInterface $index, $docId)
     {
-        $this->bulkData[] = ['delete' => ['_index' => $index->getName(), /*'_type' => '_doc',*/ '_id' => $docId]];
+        $this->bulkData[] = ['delete' => ['_index' => $index->getName(), '_id' => $docId]];
 
         return $this;
     }
@@ -100,7 +100,7 @@ public function deleteDocuments(IndexInterface $index, array $docIds)
      */
     public function updateDocument(IndexInterface $index, $docId, array $data)
     {
-        $this->bulkData[] = ['update' => ['_index' => $index->getName(), /*'_type' => '_doc',*/ '_id' => $docId]];
+        $this->bulkData[] = ['update' => ['_index' => $index->getName(), '_id' => $docId]];
         $this->bulkData[] = ['doc' => $data];
 
         return $this;

diff --git a/src/module-elasticsuite-core/Test/Unit/Index/IndexOperationTest.php b/src/module-elasticsuite-core/Test/Unit/Index/IndexOperationTest.php
@@ -124,8 +124,8 @@ public function testExecuteBulk()
         $this->clientMock->method('bulk')->will($this->returnValue([
             'errors' => true,
             'items'  => [
-                ['index' => ['_index' => 'index', '_type' => 'type', '_id' => 'doc1']],
-                ['index' => ['_index' => 'index', '_type' => 'type', '_id' => 'doc2']],
+                ['index' => ['_index' => 'index', '_id' => 'doc1']],
+                ['index' => ['_index' => 'index', '_id' => 'doc2']],
             ],
         ]));