Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fbp 224 swimlane support #291

Draft
wants to merge 48 commits into
base: master
Choose a base branch
from

Conversation

valb3r
Copy link
Owner

@valb3r valb3r commented Nov 29, 2021

Fixes #224

TODOs:

  • When adding new element outside of swimlane structure NPE happens. Add them only to UI, parentChange event to manage the rest
  • Adding element inside lane results in wrong XML (two events are necessary - flowNodeRef and actual element change in the relevant process, also correct parent selection). Can be fixed by delegating action to element like drag does
  • When dragging lane/participant/process sequence flows between elements should follow (correct parent selection is necessary and 1-2 events necessary - changing flowNodeRef and parent). Can be fixed by xml-path removal using target ID being unique value
  • References removal when dragging to other parent/deleting element
  • Resizing lane should resize parent elements too
  • Add ability to add lane
  • Add ability to add participant
  • Correct rendering of sequence elements that connect participants (cross-participant lines stop following). Can be fixed by xml-path removal using target ID being unique value
  • kotlin.TypeCastException: null cannot be cast to non-null type org.dom4j.Element when moving element within no-lane participant
  • Lane and participant should have highlighting similar to subprocess when element is dropped into them
  • com.intellij.grazie.utils.toLinkedSet is not available in older IntelliJ (DevHelper)

…mlane-support

# Conflicts:
#	activiti-intellij-plugin/build.gradle
#	build.gradle
#	camunda-intellij-plugin/build.gradle
#	flowable-intellij-plugin/build.gradle
…mlane-support

# Conflicts:
#	activiti-intellij-plugin/build.gradle
#	build.gradle
#	camunda-intellij-plugin/build.gradle
#	camunda-xml-parser/src/main/kotlin/com/valb3r/bpmn/intellij/plugin/camunda/parser/nodes/CamundaXml.kt
#	flowable-intellij-plugin/build.gradle
#	flowable-xml-parser/src/main/kotlin/com/valb3r/bpmn/intellij/plugin/flowable/parser/FlowableParser.kt
…mlane-support

# Conflicts:
#	bpmn-intellij-plugin-core/src/main/kotlin/com/valb3r/bpmn/intellij/plugin/core/state/CurrentState.kt
#	bpmn-intellij-plugin-core/src/test/kotlin/com/valb3r/bpmn/intellij/plugin/UiEditorLightE2ETest.kt
#	camunda-xml-parser/src/main/kotlin/com/valb3r/bpmn/intellij/plugin/camunda/parser/CamundaParser.kt
#	camunda-xml-parser/src/main/kotlin/com/valb3r/bpmn/intellij/plugin/camunda/parser/nodes/CamundaXml.kt
#	camunda-xml-parser/src/test/kotlin/com/valb3r/bpmn/intellij/plugin/camunda/parser/fullelements/SendTaskWithExtensionIsParseable.kt
#	camunda-xml-parser/src/test/kotlin/com/valb3r/bpmn/intellij/plugin/camunda/parser/fullelements/TaskWithExtensionIsParseable.kt
#	flowable-xml-parser/src/main/kotlin/com/valb3r/bpmn/intellij/plugin/flowable/parser/FlowableParser.kt
#	flowable-xml-parser/src/main/kotlin/com/valb3r/bpmn/intellij/plugin/flowable/parser/nodes/FlowableXml.kt
#	xml-parser-core/src/main/kotlin/com/valb3r/bpmn/intellij/plugin/bpmn/parser/core/BaseBpmnObjectFactory.kt
#	xml-parser-core/src/main/kotlin/com/valb3r/bpmn/intellij/plugin/bpmn/parser/core/BaseBpmnParser.kt
…mlane-support

# Conflicts:
#	bpmn-intellij-plugin-core/src/main/kotlin/com/valb3r/bpmn/intellij/plugin/core/render/IconProvider.kt
#	build.gradle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to add Pool and Lanes from the diagram editor ?
1 participant