Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openJDK Platform binary process runs forever #117

Closed
kozyakin opened this issue Nov 2, 2021 · 5 comments
Closed

openJDK Platform binary process runs forever #117

kozyakin opened this issue Nov 2, 2021 · 5 comments
Assignees
Labels
1-bug 🐛 Issue type: Bug report (something isn't working as expected) 2-unconfirmed Issue status: Bug that needs to be reproduced (all new bugs have this label) 3-fixed Issue resolution: Issue has been fixed on the develop branch
Milestone

Comments

@kozyakin
Copy link

kozyakin commented Nov 2, 2021

Describe the bug
After executing ltex-cli.bat on any tex-file the process openJDK Platform binary (=java.exe), which occupies about 800 MB, remains in RAM of Windows 10.

Steps to reproduce

  1. Run the command

ltex-cli.bat <tex file name>

  1. After finishing this command, inspect the running processes by Task Manager
  2. Will be seen that the process openJDK Platform binary, which occupies about 800 MB, still running in background.

Expected behavior
The process openJDK Platform binary (=java.exe) should be stopped after executing ltex-cli.bat <tex file name>

LTeX configuration
Default

Version information

  • Operating system: Windows 10 21H1
  • ltex-ls: 15.0.0
  • Java: Microsoft openJDK 17

Additional context/information
The problem may be solved by manual "killing" java, say, by insetring in the end of ltex-cli.bat the string

taskkill /f /im java.exe > nul

but this is definitely not the good solution since this string kills ALL the instances of running java.exe.

@kozyakin kozyakin added 1-bug 🐛 Issue type: Bug report (something isn't working as expected) 2-unconfirmed Issue status: Bug that needs to be reproduced (all new bugs have this label) labels Nov 2, 2021
@valentjn
Copy link
Owner

valentjn commented Nov 2, 2021

I can't reproduce this. As far as I understand, ltex-cli.bat finishes (i.e., the cmd prompt C:\...> is displayed again), but java.exe continues to run. I don't see any Java processes on my system after running ltex-cli.bat.

Can you please open a second cmd window and run wmic process where "name like 'java.exe'" get processid,commandline three times:

  • once before the execution of ltex-cli.bat,
  • once during the execution of ltex-cli.bat (cmd prompt is not yet visible),
  • once after the execution of ltex-cli.bat (cmd prompt is visible again),

and post the three outputs?

@valentjn valentjn added the 2-needs-info Issue status: We need more information (usually) from the submitter before continuing label Nov 2, 2021
@kozyakin
Copy link
Author

kozyakin commented Nov 2, 2021

Please find attached files "before", "during" and "after" of outputs of the command wmic process where "name like '%java%'" which you requested (before execution, during and after).

I also attached related screenshots of Task Manage
before.txt
during.txt
after.txt
Screenshot 2021-11-02 123259
Screenshot 2021-11-02 123415

@valentjn valentjn removed the 2-needs-info Issue status: We need more information (usually) from the submitter before continuing label Nov 2, 2021
@valentjn valentjn moved this to ⌛ In Progress in LTeX Nov 2, 2021
@valentjn valentjn added this to LTeX Nov 2, 2021
valentjn added a commit to valentjn/lsp-cli that referenced this issue Nov 2, 2021
valentjn added a commit that referenced this issue Nov 2, 2021
@valentjn
Copy link
Owner

valentjn commented Nov 2, 2021

Thanks for the info. Looks like the Java process for ltex-ls is not properly terminated by the Java process for lsp-cli.

I still can't reproduce this, even on another machine, and with the Microsoft build of OpenJDK. But I made lsp-cli terminate ltex-ls more aggressively, see commits above. Can you please test the pre-release 15.0.1-alpha.2 to see if the issue is resolved there (see docs on testing pre-releases)?

@valentjn valentjn added the 2-needs-info Issue status: We need more information (usually) from the submitter before continuing label Nov 2, 2021
@kozyakin
Copy link
Author

kozyakin commented Nov 2, 2021

Now, all is running as expected: no openJDK Platform binary process after ltex-cli.bat finished!

Well done! Great! Thanks a lot!

@valentjn valentjn moved this from ⌛ In Progress to 🎉 Done in LTeX Nov 2, 2021
@valentjn valentjn self-assigned this Nov 2, 2021
@valentjn valentjn added this to the 15.0.1 milestone Nov 2, 2021
@valentjn valentjn added 3-fixed Issue resolution: Issue has been fixed on the develop branch and removed 2-needs-info Issue status: We need more information (usually) from the submitter before continuing labels Nov 2, 2021
@github-actions
Copy link

github-actions bot commented Nov 2, 2021

This issue is now fixed on develop. The fix will be included in the next release of LTEX.

If you don't want to wait, you can try out the nightly pre-release tomorrow. Nightly pre-releases are published every morning at around 4am UTC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-bug 🐛 Issue type: Bug report (something isn't working as expected) 2-unconfirmed Issue status: Bug that needs to be reproduced (all new bugs have this label) 3-fixed Issue resolution: Issue has been fixed on the develop branch
Projects
Archived in project
Development

No branches or pull requests

2 participants