Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting invalid by default #41

Closed
PierreMarchand20 opened this issue May 24, 2020 · 2 comments
Closed

Setting invalid by default #41

PierreMarchand20 opened this issue May 24, 2020 · 2 comments
Assignees
@valentjn
Labels
1-bug 🐛 Issue type: Bug report (something isn't working as expected) 2-confirmed Issue status: Confirmed, reproducible bug in LTeX 3-fixed Issue resolution: Issue has been fixed on the develop branch
Milestone
5.0.0

Comments

@PierreMarchand20
Copy link

Describe the bug
I just installed this extension and it seems that there is an issue with the settings:
image

But when I add them
image

it removes the warning.

Steps to reproduce
Steps to reproduce the behavior:

  1. I just installed the extension and its French version and I did not touch anything.

LTeX configuration
Please attach any LTeX-related configuration settings from your settings.json.

** Log files**
First, set the ltex.trace.server setting in your settings.json to "verbose". Then, reload the VS Code window and reproduce the bug. Go to View → Output and select LTeX Language Server and LTeX Language Client in the drop-down list. Paste or attach the relevant parts of these logs here in the GitHub issue.

Version information
List here the version information of the relevant software.

  • Operating system: macOS xx.xx
  • VS Code: 1.45.1
  • LTeX: 4.9.3
  • LTeX language extensions: French
  • Java:
    openjdk 11.0.2 2019-01-15
    OpenJDK Runtime Environment 18.9 (build 11.0.2+9)
    OpenJDK 64-Bit Server VM 18.9 (build 11.0.2+9, mixed mode)
    Additional context/information
    I actually tried to add the feature of this extension in Latex-Utility (but not maintained anymore), so I am quite happy to discover this extension!
@PierreMarchand20 PierreMarchand20 added 1-bug 🐛 Issue type: Bug report (something isn't working as expected) 2-unconfirmed Issue status: Bug that needs to be reproduced (all new bugs have this label) labels May 24, 2020
@valentjn valentjn self-assigned this May 24, 2020
@valentjn valentjn added 2-confirmed Issue status: Confirmed, reproducible bug in LTeX and removed 2-unconfirmed Issue status: Bug that needs to be reproduced (all new bugs have this label) labels May 24, 2020
@valentjn valentjn added this to the 5.0.0 milestone May 24, 2020
valentjn added a commit that referenced this issue May 24, 2020
@valentjn
Don't use null as default for settings
c6f0898 
Fixes #41.
@valentjn
Copy link
Owner

Thanks for the report. I noticed this a few days ago. It should be fixed on the 5.x branch.

valentjn added a commit that referenced this issue May 24, 2020
@valentjn
Don't use null as default for settings
66f83e6 
Fixes #41.
@valentjn valentjn added the 3-fixed Issue resolution: Issue has been fixed on the develop branch label May 24, 2020
@valentjn
Copy link
Owner

valentjn commented Jun 1, 2020

Fix released in 5.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentjn valentjn

Labels
1-bug 🐛 Issue type: Bug report (something isn't working as expected) 2-confirmed Issue status: Confirmed, reproducible bug in LTeX 3-fixed Issue resolution: Issue has been fixed on the develop branch
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
2 participants
@PierreMarchand20 @valentjn