Skip to content

Commit

Permalink
Feature/add extra volumes and extra volume mounts to workers (#201)
Browse files Browse the repository at this point in the history
* Added extraVolumes and extraVolumeMounts configuration

* helm-docs

* version 9.2.0

* description of changes in chart annotations

* fixed identation for example

---------

Co-authored-by: cccs-nik <68961854+cccs-nik@users.noreply.github.com>
  • Loading branch information
cccs-mmrouet and cccs-nik authored Apr 22, 2024
1 parent 5e8e217 commit 521120a
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 3 deletions.
4 changes: 2 additions & 2 deletions valeriano-manassero/trino/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v1
appVersion: "433"
description: High performance, distributed SQL query engine for big data
name: trino
version: 9.1.1
version: 9.2.0
kubeVersion: ">= 1.24.0-0 < 1.29.0-0"
home: https://trino.io
icon: https://trino.io/assets/images/trino-logo/trino-ko_tiny-alt.svg
Expand All @@ -27,4 +27,4 @@ keywords:
annotations:
artifacthub.io/changes: |
- kind: changed
description: Fix worker initContainer condition so it is done on worker and not on coordinator.
description: Add the capability to configure extra volumes and extra volume mounts.
4 changes: 3 additions & 1 deletion valeriano-manassero/trino/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# trino

![Version: 9.1.1](https://img.shields.io/badge/Version-9.1.1-informational?style=flat-square) ![AppVersion: 433](https://img.shields.io/badge/AppVersion-433-informational?style=flat-square)
![Version: 9.2.0](https://img.shields.io/badge/Version-9.2.0-informational?style=flat-square) ![AppVersion: 433](https://img.shields.io/badge/AppVersion-433-informational?style=flat-square)

High performance, distributed SQL query engine for big data

Expand Down Expand Up @@ -72,6 +72,8 @@ Kubernetes: `>= 1.24.0-0 < 1.29.0-0`
| config.worker.env | list | `[]` | |
| config.worker.envFrom | list | `[]` | |
| config.worker.extraConfig | string | `""` | |
| config.worker.extraVolumeMounts | object | `{}` | |
| config.worker.extraVolumes | object | `{}` | |
| config.worker.initContainers | list | `[]` | |
| config.worker.jvm.gcMethod.g1.heapRegionSize | string | `"32M"` | |
| config.worker.jvm.gcMethod.type | string | `"UseG1GC"` | |
Expand Down
8 changes: 8 additions & 0 deletions valeriano-manassero/trino/templates/deployment-worker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,10 @@ spec:
configMap:
name: {{ .configMapName }}
{{- end }}
{{- range $volumeName, $volume := .Values.config.worker.extraVolumes }}
- name: {{ $volumeName }}
{{- tpl (toYaml $volume) $ | nindent 10 -}}
{{- end }}
{{- if or .Values.jmxExporter.worker.enabled .Values.config.worker.initContainers }}
initContainers:
{{- if .Values.jmxExporter.worker.enabled }}
Expand Down Expand Up @@ -152,6 +156,10 @@ spec:
subPath: {{ .subPath }}
{{- end }}
{{- end }}
{{- range $mountName, $mount := .Values.config.worker.extraVolumeMounts }}
- name: {{ $mountName }}
{{- tpl (toYaml $mount) $ | nindent 14 -}}
{{- end }}
{{- if .Values.jmxExporter.worker.enabled }}
ports:
- name: jmx-exporter
Expand Down
10 changes: 10 additions & 0 deletions valeriano-manassero/trino/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,16 @@ config:
# preStop:
# exec:
# command: ["sh", "-c", "curl -v -X PUT -d '\"SHUTTING_DOWN\"' -H \"Content-type: application/json\" -H \"X-Trino-User: admin\" http://localhost:8080/v1/info/state"]
extraVolumeMounts: {}
# sample config for temp storage volume mount
# localtemp:
# mountpath: /tmp/localtemp
# readOnly: false
extraVolumes: {}
# sample config for temp storage volume
# localtemp:
# hostPath:
# path: /mnt


eventListenerProperties: {}
Expand Down

0 comments on commit 521120a

Please sign in to comment.