-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support multiple configurations as an object not a single string #151
support multiple configurations as an object not a single string #151
Conversation
@valeriano-manassero! |
Pls generate README with helm-docs and commit it. |
Thanks, Looks good now. |
I'd like to see version 3.0.0 instead of 2.8.2. This is because we are in front of a potential breaking change (especially if someone already is using extraConfig). |
@hafizmujadidKhalid Sounds like you were getting a single line string because you don't know how to use multi-line strings? Please refer to this documentation: https://helm.sh/docs/chart_template_guide/yaml_techniques/#strings-in-yaml. I've only ever seen multi-line strings used to populate data into ConfigMaps for something like this. While this change "works" (although not implemented properly: Would it please be possible to revert this change? @valeriano-manassero Thanks. |
I will do another major release with rollback. Sorry I accepted the PR without having you as reviewer. Maybe I can add you next time. |
Yeah no worries, I can help with reviews. Feel free to add me on future PRs. |
Hello,
I was trying to add some additional configurations such as below:
But it adds both properties in a single line as
extraConfig: ""
is a string value. We should make it an object and store all extra configuration in config.properties as it is given by the user.This PR fixes issue #150