-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust: add v1.72.0 for zenoh-c/0.10.1-rc #6
base: new/rust-prebuilt
Are you sure you want to change the base?
Conversation
* Arrow: Refactor auto options * add todo * make boost compulsory in msvc * enable parquet and thrift by default * bump boost version to avoid conflicts with thrift's * try with re2 * bool compute * back to previous default values * avoid config * fix * Arrow: remove dead code (#6) * remove dead code * fix indentation * Update recipes/arrow/all/conanfile.py * remove warnings --------- Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
@oteffahi
Is this still relevant if we are building zenoh-c from scratch instead of using prebuilt binaries? Even then, Rust stdlib and other libraries are linked statically into the library, so I think the Rust version still should not really matter? |
Hello @valgur, |
Makes sense, thanks! I'll downgrade the version in the Rust recipe to 1.72.0. |
Actually, on second thought, I would assume that 1.72.1 is still compatible with binaries built with the .0 version. Correct me if I'm wrong. |
@valgur sorry for the late reply. We haven't tested this, but ideally to avoid any possible issues it's better to use the exact same version. Note that we maintain a rust-toolchain.toml file which contains the exact version to be used when compiling the project. This version is downloaded and installed automatically by Cargo if building without providing a channel (i.e using I understand that you may want to support the latest patch of each minor version of Rust, but projects can require a specific version through their |
This PR adds Rust 1.72.0.
As mentionned in the Zenoh-C CCI PR, it would be ideal to have Rust 1.72.0 to ensure compatibility with Zenoh-C's 0.10.1-rc release artefacts, mainly regarding plugins.