Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: add v1.72.0 for zenoh-c/0.10.1-rc #6

Open
wants to merge 1 commit into
base: new/rust-prebuilt
Choose a base branch
from

Conversation

oteffahi
Copy link

@oteffahi oteffahi commented Apr 5, 2024

This PR adds Rust 1.72.0.

As mentionned in the Zenoh-C CCI PR, it would be ideal to have Rust 1.72.0 to ensure compatibility with Zenoh-C's 0.10.1-rc release artefacts, mainly regarding plugins.

valgur pushed a commit that referenced this pull request Apr 9, 2024
* Arrow: Refactor auto options

* add todo

* make boost compulsory in msvc

* enable parquet and thrift by default

* bump boost version to avoid conflicts with thrift's

* try with re2

* bool compute

* back to previous default values

* avoid config

* fix

* Arrow: remove dead code (#6)

* remove dead code

* fix indentation

* Update recipes/arrow/all/conanfile.py

* remove warnings

---------

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
@valgur
Copy link
Owner

valgur commented Apr 16, 2024

@oteffahi
I already added 1.72, but added 1.72.1 instead of 1.72.0. Is that ok?

As mentionned in the Zenoh-C CCI PR, it would be ideal to have Rust 1.72.0 to ensure compatibility with Zenoh-C's 0.10.1-rc release artefacts, mainly regarding plugins.

Is this still relevant if we are building zenoh-c from scratch instead of using prebuilt binaries? Even then, Rust stdlib and other libraries are linked statically into the library, so I think the Rust version still should not really matter?

@oteffahi
Copy link
Author

Hello @valgur,
Rust 1.72.0 is required in order for the resulting build to be compatible with prebuilt plugins and backends that are part of the 0.10.1-rc release. Zenoh users tend to want to use those without going through the bother of compiling them from source, so we want them to be supported if possible. This requires that both zenoh and the plugins must be built with the same Rust version, which in the case of 0.10.1-rc happens to be 1.72.0.
I hope this answers your question regarding this requirement.

@valgur
Copy link
Owner

valgur commented Apr 16, 2024

Makes sense, thanks! I'll downgrade the version in the Rust recipe to 1.72.0.

@valgur
Copy link
Owner

valgur commented Apr 16, 2024

Actually, on second thought, I would assume that 1.72.1 is still compatible with binaries built with the .0 version. Correct me if I'm wrong.

@oteffahi
Copy link
Author

Actually, on second thought, I would assume that 1.72.1 is still compatible with binaries built with the .0 version. Correct me if I'm wrong.

@valgur sorry for the late reply. We haven't tested this, but ideally to avoid any possible issues it's better to use the exact same version. Note that we maintain a rust-toolchain.toml file which contains the exact version to be used when compiling the project. This version is downloaded and installed automatically by Cargo if building without providing a channel (i.e using cargo build instead of cargo +stable build or cargo +1.72.1 build for example)

I understand that you may want to support the latest patch of each minor version of Rust, but projects can require a specific version through their rust-toolchain.toml file, which might not be on the latest patch. In our case this is done in order to ensure compatibility with release artefacts (plugins).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants