Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add revive linter, fix linting errors, remove unused code #63

Merged
merged 5 commits into from
Jul 10, 2024
Merged

refactor: add revive linter, fix linting errors, remove unused code #63

merged 5 commits into from
Jul 10, 2024

Conversation

mattwelke
Copy link
Member

No description provided.

@mattwelke
Add revive linter. Fix linting errors. Remove unused code.
f499fb3 
Signed-off-by: Matt Welke <matt.welke@spectrocloud.com>
@mattwelke mattwelke requested a review from a team as a code owner July 10, 2024 17:09
@mattwelke
Update chart.
c2c56fd 
Signed-off-by: Matt Welke <matt.welke@spectrocloud.com>
@mattwelke
Restore chart. Update it with new CRD.
9624e23 
Signed-off-by: Matt Welke <matt.welke@spectrocloud.com>
@mattwelke
Update copyright to 2024.
41fce00 
Signed-off-by: Matt Welke <matt.welke@spectrocloud.com>
@mattwelke
Fix comment.
fc59c77 
Signed-off-by: Matt Welke <matt.welke@spectrocloud.com>
mattwelke
mattwelke commented Jul 10, 2024
View reviewed changes
internal/validators/kubescape.go
@@ -51,7 +54,8 @@ func (n *KubescapeService) Manifests() ([]kubescapev1.VulnerabilityManifest, err
return manifests, nil
}

func (n *KubescapeService) ReconcileSeverityRule(nn ktypes.NamespacedName, rule validationv1.SeverityLimitRule, ignoredCVEs []string, manifests []kubescapev1.VulnerabilityManifest) (*types.ValidationRuleResult, error) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Param ignoredCVEs was unused. The refactor went all the way up to spec. I figured it's best to reintroduce it to the spec after we implement it instead of keeping it in the spec but unused til then.

@TylerGillson TylerGillson mentioned this pull request Jul 10, 2024
Open
@codecov Codecov
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

@@          Coverage Diff          @@
##            main     #63   +/-   ##
=====================================
  Coverage   0.61%   0.62%           
=====================================
  Files          5       5           
  Lines        325     320    -5     
=====================================
  Hits           2       2           
+ Misses       323     318    -5
Files Coverage Δ
api/v1alpha1/kubescapevalidator_types.go 16.66% <ø> (+1.28%) ⬆️
api/v1alpha1/zz_generated.deepcopy.go 0.00% <ø> (ø)
cmd/main.go 0.00% <ø> (ø)
...ternal/controller/kubescapevalidator_controller.go 0.00% <0.00%> (ø)
internal/validators/kubescape.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14f18c7...fc59c77. Read the comment docs.

@mattwelke mattwelke merged commit a476942 into main Jul 10, 2024
6 of 7 checks passed
@mattwelke mattwelke deleted the chore/linting branch July 10, 2024 17:52
@TylerGillson TylerGillson mentioned this pull request Jun 27, 2024
Merged
ahmad-ibra pushed a commit that referenced this pull request Jul 26, 2024
@TylerGillson
chore(main): release 0.0.4 (#54)
7f7410c 
🤖 I have created a release *beep* *boop*
---


##
[0.0.4](v0.0.3...v0.0.4)
(2024-07-26)


### Bug Fixes

* add reviewable-ext target to Makefile
([#74](#74))
([14ee619](14ee619))
* **deps:** update kubernetes packages to v0.30.1
([#6](#6))
([ac6621e](ac6621e))
* **deps:** update kubernetes packages to v0.30.2
([#55](#55))
([9b4a1e3](9b4a1e3))
* **deps:** update module github.com/go-logr/logr to v1.4.2
([#42](#42))
([1144675](1144675))
* **deps:** update module github.com/kubescape/kubevuln to v0.3.18
([#15](#15))
([4e51614](4e51614))
* **deps:** update module github.com/kubescape/kubevuln to v0.3.22
([#35](#35))
([326bf43](326bf43))
* **deps:** update module github.com/kubescape/kubevuln to v0.3.25
([#47](#47))
([94ab793](94ab793))
* **deps:** update module github.com/kubescape/storage to v0.0.85
([#43](#43))
([bf48573](bf48573))
* **deps:** update module github.com/kubescape/storage to v0.0.89
([#56](#56))
([d71438c](d71438c))
* **deps:** update module github.com/onsi/ginkgo/v2 to v2.17.3
([#13](#13))
([88d02dd](88d02dd))
* **deps:** update module github.com/onsi/ginkgo/v2 to v2.19.0
([#37](#37))
([863cc5f](863cc5f))
* **deps:** update module github.com/onsi/gomega to v1.33.1
([#14](#14))
([ca03daa](ca03daa))
* **deps:** update module github.com/validator-labs/validator to v0.0.41
([#44](#44))
([fa6b6ba](fa6b6ba))
* **deps:** update module github.com/validator-labs/validator to v0.0.42
([#52](#52))
([5459604](5459604))
* **deps:** update module github.com/validator-labs/validator to v0.0.43
([#57](#57))
([8865d3f](8865d3f))
* **deps:** update module sigs.k8s.io/cluster-api to v1.7.2
([#7](#7))
([ca981d2](ca981d2))
* **deps:** update module sigs.k8s.io/cluster-api to v1.7.3
([#53](#53))
([8950f34](8950f34))
* **deps:** update module sigs.k8s.io/controller-runtime to v0.18.4
([#50](#50))
([fbe1e36](fbe1e36))


### Other

* **deps:** pin googleapis/release-please-action action to f3969c0
([#33](#33))
([62f2d2f](62f2d2f))
* **deps:** update actions/checkout digest to a5ac7e5
([#34](#34))
([5242581](5242581))
* **deps:** update actions/setup-go digest to cdcb360
([#38](#38))
([75fdbed](75fdbed))
* **deps:** update anchore/sbom-action action to v0.15.11
([#23](#23))
([18db034](18db034))
* **deps:** update anchore/sbom-action action to v0.16.0
([#36](#36))
([aba05a9](aba05a9))
* **deps:** update codecov/codecov-action digest to 125fc84
([#39](#39))
([b83a720](b83a720))
* **deps:** update docker/login-action digest to 0d4c9c5
([#40](#40))
([2605655](2605655))
* **deps:** update docker/setup-buildx-action digest to d70bba7
([#22](#22))
([0b1f3d9](0b1f3d9))
* **deps:** update gcr.io/kubebuilder/kube-rbac-proxy docker tag to
v0.16.0
([#11](#11))
([8227a36](8227a36))
* **deps:** update helm/kind-action action to v1.10.0
([#25](#25))
([69e8a63](69e8a63))
* **deps:** update softprops/action-gh-release digest to 69320db
([#41](#41))
([374afe4](374afe4))


### Dependency Updates

* **deps:** update kubernetes packages to v0.30.3
([#67](#67))
([f18633b](f18633b))
* **deps:** update module github.com/kubescape/storage to v0.0.90
([#68](#68))
([1e6926f](1e6926f))
* **deps:** update module github.com/onsi/gomega to v1.34.0
([#72](#72))
([f5c3d9a](f5c3d9a))
* **deps:** update module github.com/validator-labs/validator to v0.0.44
([#64](#64))
([82b90c4](82b90c4))
* **deps:** update module github.com/validator-labs/validator to v0.0.46
([#66](#66))
([67f9276](67f9276))
* **deps:** update module github.com/validator-labs/validator to v0.0.47
([#69](#69))
([b47fe95](b47fe95))
* **deps:** update module github.com/validator-labs/validator to v0.0.48
([#70](#70))
([6da6570](6da6570))
* **deps:** update module github.com/validator-labs/validator to v0.0.49
([#71](#71))
([ace693a](ace693a))


### Refactoring

* add revive linter, fix linting errors, remove unused code
([#63](#63))
([a476942](a476942))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerGillson TylerGillson TylerGillson approved these changes

@arturshadnik arturshadnik Awaiting requested review from arturshadnik arturshadnik is a code owner automatically assigned from validator-labs/validator

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattwelke @TylerGillson