feat: add support for configuring signature verification pubkeys inline #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #289 +/- ##
==========================================
- Coverage 62.66% 59.71% -2.96%
==========================================
Files 8 8
Lines 458 484 +26
==========================================
+ Hits 287 289 +2
- Misses 142 165 +23
- Partials 29 30 +1
Continue to review full report in Codecov by Sentry.
|
ahmad-ibra
force-pushed
the
feat/add-direct-helpers
branch
from
f9b33d1
to
79a30f2
Compare
ahmad-ibra
force-pushed
the
feat/add-direct-helpers
branch
from
79a30f2
to
f697dc7
Compare
…ubkeys are provided
ahmad-ibra
force-pushed
the
feat/add-direct-helpers
branch
from
f697dc7
to
a35b98a
Compare
dosubot
bot
added
the
size:L
TylerGillson
reviewed
Sep 4, 2024
TylerGillson
approved these changes
Sep 4, 2024
ahmad-ibra
pushed a commit
that referenced
this pull request
Sep 4, 2024
🤖 I have created a release *beep* *boop* --- ## [0.3.3](v0.3.2...v0.3.3) (2024-09-04) ### Features * add support for configuring signature verification pubkeys inline ([#289](#289)) ([a9c17b5](a9c17b5)) ### Dependency Updates * **deps:** update github.com/awslabs/amazon-ecr-credential-helper/ecr-login digest to 5dc58b6 ([#284](#284)) ([7efe2ad](7efe2ad)) * **deps:** update module github.com/onsi/ginkgo/v2 to v2.20.2 ([#286](#286)) ([846edc6](846edc6)) * **deps:** update module github.com/onsi/gomega to v1.34.2 ([#287](#287)) ([d527f3c](d527f3c)) * **deps:** update module github.com/sigstore/sigstore to v1.8.9 ([#288](#288)) ([e4d1fa8](e4d1fa8)) * **deps:** update module github.com/validator-labs/validator to v0.1.9 ([#277](#277)) ([7089509](7089509)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
|
This also Resolves validator-labs/validatorctl#174 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #279
Description
PublicKeysfield to theSignatureVerifcationstruct.PublicKeysfield is checked.BasicAuthsDirectandAllPubKeysDirectfrom validatorctl to the plugin.AllPublicKeysDirectwhere we were using an array instead of a map