chore: cleanup more unused functions

Makefile

@@ -7,9 +7,7 @@
 
 # Images
 IMAGE_TAG ?= latest
-
-# TODO: update this image location
-CLI_IMG ?= "gcr.io/spectro-common-dev/${USER}/validator:$(IMAGE_TAG)"
+CLI_IMG ?= "quay.io/validator-labs/validatorctl:$(IMAGE_TAG)"
 
 # Dependency Versions
 BUILDER_GOLANG_VERSION ?= 1.22

pkg/config/constants.go

@@ -66,7 +66,7 @@ const (
 
 	// Embed dirs
 	Kind      string = "kind"
-	Validator string = "validator" // TODO: should this be an embeded dir?
+	Validator string = "validator"
 
 	// regex
 	DomainRegex          = "([a-zA-Z0-9]{1,63}|[a-zA-Z0-9][a-zA-Z0-9\\-]{0,61}[a-zA-Z0-9])(\\.[a-zA-Z0-9]{1,63}|\\.[a-zA-Z0-9][a-zA-Z0-9\\-]{0,61}[a-zA-Z0-9]){0,10}\\.([a-zA-Z0-9][a-zA-Z0-9\\-]{0,61}[a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9\\-]{0,30}[a-zA-Z0-9]\\.[a-zA-Z]{2,})"
@@ -97,7 +97,7 @@ var (
 		ValidatorPluginAws:     "v0.0.26",
 		ValidatorPluginAzure:   "v0.0.11",
 		ValidatorPluginNetwork: "v0.0.16",
-		ValidatorPluginVsphere: "v0.0.23",
+		ValidatorPluginVsphere: "v0.0.24",
 		ValidatorPluginOci:     "v0.0.10",
 	}
 

pkg/utils/embed/embed.go

@@ -17,7 +17,6 @@ import (
 	log "github.com/validator-labs/validatorctl/pkg/logging"
 )
 
-// TODO: remove  any binaries we dont need
 var Docker, Helm, Kind, Kubectl string
 
 //go:embed bin/docker

tests/utils/file/directory.go

@@ -9,14 +9,6 @@ import (
 
 const testDir = "tests"
 
-func VCenterRepoPath() string {
-	return fmt.Sprintf("%s/%s", HomePath(testDir), "tests/external/repo/vcenter")
-}
-
-func HelperTestCasesPath() string {
-	return fmt.Sprintf("%s/%s", HomePath(testDir), "tests/integration/helper/testcases")
-}
-
 func ValidatorTestCasesPath() string {
 	// note: '_validator' was used here, rather than 'validator', due to: https://github.com/helm/helm/issues/7862
 	return fmt.Sprintf("%s/%s", HomePath(testDir), "tests/integration/_validator/testcases")