Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Set exit code for validator check --direct according to validation results #138

Closed
TylerGillson opened this issue Aug 7, 2024 · 0 comments · Fixed by #150
Closed

🌱 Set exit code for validator check --direct according to validation results #138

TylerGillson opened this issue Aug 7, 2024 · 0 comments · Fixed by #150
Assignees
@TylerGillson
Labels
enhancement Enhancement to an existing feature

Comments

@TylerGillson
Copy link
Member

Summary

If any validation result failed, the exit code must be 1, not 0.
@TylerGillson TylerGillson added the enhancement Enhancement to an existing feature label Aug 7, 2024
@TylerGillson TylerGillson self-assigned this Aug 7, 2024
@TylerGillson TylerGillson mentioned this issue Aug 9, 2024
Merged
TylerGillson added a commit that referenced this issue Aug 9, 2024
@TylerGillson
feat: set exit code 2 on validation failure; restore debug log file (#…
2a3fe4d 
…150)

## Issue
Resolves #138 

## Description
- Set exit code 2 for `validator rules check` if validation fails for
any rule.
- Document exit codes.
- Re-enable logging to disk under unique log directory per
`validatorctl` execution.

---------

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TylerGillson TylerGillson

Labels
enhancement Enhancement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: set exit code 2 on validation failure; restore debug log file validator-labs/validatorctl
1 participant
@TylerGillson