chore: clean up helpers for setting up oci network and vsphere validation rules #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmad-ibra
force-pushed
the
feat/add-configure-validation-helpers
branch
from
9771d46
to
c0b5a22
Compare
ahmad-ibra
changed the title
ahmad-ibra
force-pushed
the
feat/add-configure-validation-helpers
branch
from
c0b5a22
to
67e30e2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #137 +/- ##
==========================================
+ Coverage 37.60% 38.34% +0.74%
==========================================
Files 44 41 -3
Lines 5435 5330 -105
==========================================
Hits 2044 2044
+ Misses 3005 2900 -105
Partials 386 386
Continue to review full report in Codecov by Sentry.
|
dosubot
bot
added
size:L
TylerGillson
approved these changes
Aug 7, 2024
ahmad-ibra
pushed a commit
that referenced
this pull request
Aug 8, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.1](v0.1.0...v0.1.1) (2024-08-08) ### Other * clean up helpers for setting up oci network and vsphere validation rules ([#137](#137)) ([dbdee2f](dbdee2f)) ### Docs * update docs to reflect recent api changes ([#146](#146)) ([f2b3217](f2b3217)) ### Dependency Updates * **deps:** update github.com/validator-labs/validator-plugin-azure digest to 862db62 ([#142](#142)) ([039e6f0](039e6f0)) * **deps:** update github.com/validator-labs/validator-plugin-vsphere digest to d7deabd ([#143](#143)) ([72267ad](72267ad)) * **deps:** update module github.com/validator-labs/validator-plugin-oci to v0.1.0 ([#132](#132)) ([8862bb5](8862bb5)) ### Refactoring * add rules subcommand & split out apply/check ([#144](#144)) ([e88bd71](e88bd71)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These helpers are no longer required as we can now easily invoke validator check in
--directmode