Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove subcommand docs from repo #205

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

mattwelke
Copy link
Member

@mattwelke mattwelke commented Sep 3, 2024

Description

We have command reference docs on our main documentation site now. See https://validator-labs.github.io/docs.

validator-labs/docs#3 must be merged first.

@mattwelke mattwelke requested a review from a team as a code owner September 3, 2024 16:24
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. documentation Improvements or additions to documentation labels Sep 3, 2024
TylerGillson
TylerGillson previously approved these changes Sep 3, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff           @@
##             main     #205   +/-   ##
=======================================
  Coverage   53.33%   53.33%           
=======================================
  Files          45       45           
  Lines        6253     6253           
=======================================
  Hits         3335     3335           
  Misses       2073     2073           
  Partials      845      845           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7408a6...a936c65. Read the comment docs.

mattwelke added a commit to validator-labs/docs that referenced this pull request Sep 5, 2024
## Description
The first real update to the repo to add our docs contents.

* Removes Docusaurus and Facebook branding. Replaces it with a slight
modification of the built in theme to replace the green color palette
with a blue one. New graphics from [SVG Repo](https://www.svgrepo.com)
and [undraw](https://undraw.co/) that use blue and orange as their color
scheme. This is designed to match the blue and orange we got from our
AI-generated logo.
* Replaces placeholder docs content with content for Validator. A
Community page links them to all the ways they can get in touch with us.
* Removes `test-deploy.yml` GHA workflow. It was redundant because we
have Netlify trying to build our site which is set up as a required
check. If site builds are broken, PRs cannot be merged.

I also wanted to add a call to action to the splash page (maybe a "read
more" button to bring them to the first docs page) but I couldn't figure
out the CSS for now. Maybe we can add that later.

When this is merged, other changes should be made to remove
documentation that we're centralizing here:

* validator-labs/validatorctl#205
* Clear away description from GitHub org page, replace it with something
short and sweet with a link to the new docs site.

---------

Signed-off-by: Matt Welke <matt.welke@spectrocloud.com>
We have command reference docs on our main documentation site now.

Signed-off-by: Matt Welke <matt.welke@spectrocloud.com>
Signed-off-by: Matt Welke <matt.welke@spectrocloud.com>
@TylerGillson TylerGillson merged commit 57ca6cb into main Sep 5, 2024
8 checks passed
@TylerGillson TylerGillson deleted the chore/remove-subdommand-docs branch September 5, 2024 18:49
TylerGillson added a commit that referenced this pull request Sep 11, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.2.0](v0.1.4...v0.2.0)
(2024-09-11)


### ⚠ BREAKING CHANGES

* remove role privilege rules
([#217](#217))

### Features

* add --custom-resources flag to validator rules check as an alternate
to -f
([#218](#218))
([4aa14b6](4aa14b6))


### Bug Fixes

* add missing Host.Config.Storage privilege & document
([#212](#212))
([c7408a6](c7408a6))


### Docs

* remove subcommand docs from repo
([#205](#205))
([57ca6cb](57ca6cb))


### Dependency Updates

* **deps:** update golang.org/x/exp digest to e7e105d
([#214](#214))
([c4ac163](c4ac163))


### Refactoring

* remove role privilege rules
([#217](#217))
([b0976db](b0976db))
* update `executePlugins` function to operate on a slice of
`PluginSpec`'s
([#206](#206))
([97875f3](97875f3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants