-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove vsphere palette oriented resources #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmad-ibra
force-pushed
the
chore/remove-palette
branch
2 times, most recently
from
June 19, 2024 18:46
4a62e7a
to
86a5e51
Compare
ahmad-ibra
force-pushed
the
chore/remove-palette
branch
from
June 19, 2024 20:04
86a5e51
to
4cdfda4
Compare
ahmad-ibra
changed the title
chore: remove spectro resources
chore: remove vsphere palette oriented resources
Jun 19, 2024
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## main #34 +/- ##
==========================================
+ Coverage 54.44% 55.49% +1.05%
==========================================
Files 41 41
Lines 4232 4166 -66
==========================================
+ Hits 2304 2312 +8
+ Misses 1345 1267 -78
- Partials 583 587 +4
Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Ahmad Malik Ibrahim <ahmad.ibrahim@spectrocloud.com>
Release-As: 0.0.1 Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Ahmad Malik Ibrahim <ahmad.ibrahim@spectrocloud.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
TylerGillson
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#12
#38
Description
Removing all palette oriented vsphere things from validatorctl. This entails setting up
role privilege
,entity privilege
, andtag validation
rules to only support custom setup.