Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove vsphere palette oriented resources #34

Merged
merged 23 commits into from
Jun 19, 2024

Conversation

ahmad-ibra
Copy link
Collaborator

@ahmad-ibra ahmad-ibra commented Jun 19, 2024

Issue

#12
#38

Description

Removing all palette oriented vsphere things from validatorctl. This entails setting up role privilege, entity privilege, and tag validation rules to only support custom setup.

@ahmad-ibra ahmad-ibra force-pushed the chore/remove-palette branch 2 times, most recently from 4a62e7a to 86a5e51 Compare June 19, 2024 18:46
@ahmad-ibra ahmad-ibra changed the title chore: remove spectro resources chore: remove vsphere palette oriented resources Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 83.72093% with 14 lines in your changes missing coverage. Please review.

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   54.44%   55.49%   +1.05%     
==========================================
  Files          41       41              
  Lines        4232     4166      -66     
==========================================
+ Hits         2304     2312       +8     
+ Misses       1345     1267      -78     
- Partials      583      587       +4     
Files Coverage Δ
pkg/components/validator.go 60.31% <ø> (ø)
pkg/config/constants.go 100.00% <ø> (ø)
...integration/_validator/testcases/test_validator.go 94.52% <100.00%> (+0.13%) ⬆️
pkg/services/validator/vmware.go 41.32% <41.66%> (+4.24%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52c7b46...c070ff0. Read the comment docs.

TylerGillson and others added 4 commits June 19, 2024 15:32
Release-As: 0.0.1
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@ahmad-ibra ahmad-ibra marked this pull request as ready for review June 19, 2024 21:52
@ahmad-ibra ahmad-ibra requested a review from a team as a code owner June 19, 2024 21:52
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@ahmad-ibra ahmad-ibra merged commit 9213c76 into main Jun 19, 2024
7 checks passed
@ahmad-ibra ahmad-ibra deleted the chore/remove-palette branch June 19, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants