-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add helpers to easily configure validator plugins #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## main #62 +/- ##
==========================================
- Coverage 55.65% 53.70% -1.95%
==========================================
Files 40 43 +3
Lines 4436 4597 +161
==========================================
Hits 2469 2469
- Misses 1338 1500 +162
+ Partials 629 628 -1
Continue to review full report in Codecov by Sentry.
|
…ur validator config
TylerGillson
approved these changes
Jun 27, 2024
ahmad-ibra
pushed a commit
that referenced
this pull request
Jun 27, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.3](v0.0.2...v0.0.3) (2024-06-27) ### Features * add helpers to easily configure validator plugins ([#62](#62)) ([ae596d3](ae596d3)) ### Dependency Updates * **deps:** update module github.com/vmware/govmomi to v0.38.0 ([#59](#59)) ([4e6ad15](4e6ad15)) * **deps:** update module gopkg.in/yaml.v2 to v3 ([#57](#57)) ([9698478](9698478)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setup the following helper functions to easily configure vsphere, oci, and network validator plugins and to generate the validator config file:
Other small fixes
ConfigFile
andValidatorConfigFile
are not bothvalidator.yaml
.ConfigFile
is nowvalidatorctl.yaml
/bin
base dir is never created. This is not needed becausevalidatorctl
does not install the helm/docker/kubectl/kind binaries