Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add helpers to easily configure validator plugins #62

Merged
merged 9 commits into from
Jun 27, 2024

Conversation

ahmad-ibra
Copy link
Collaborator

@ahmad-ibra ahmad-ibra commented Jun 26, 2024

Description

Setup the following helper functions to easily configure vsphere, oci, and network validator plugins and to generate the validator config file:

  • ConfigureBaseValidator(...)
  • ConfigureVspherePlugin(...)
  • ConfigureNetworkPlugin(...)
  • ConfigureOciPlugin(...)

Other small fixes

  • Ensured ConfigFile and ValidatorConfigFile are not both validator.yaml. ConfigFile is now validatorctl.yaml
  • Ensure that the /bin base dir is never created. This is not needed because validatorctl does not install the helm/docker/kubectl/kind binaries

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 7.77778% with 166 lines in your changes missing coverage. Please review.

@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
- Coverage   55.65%   53.70%   -1.95%     
==========================================
  Files          40       43       +3     
  Lines        4436     4597     +161     
==========================================
  Hits         2469     2469              
- Misses       1338     1500     +162     
+ Partials      629      628       -1     
Files Coverage Δ
pkg/config/manager/config_manager.go 100.00% <100.00%> (+20.00%) ⬆️
pkg/components/network.go 0.00% <0.00%> (ø)
pkg/components/validator.go 55.92% <23.07%> (-4.24%) ⬇️
pkg/components/oci.go 0.00% <0.00%> (ø)
pkg/cmd/validator/validator.go 52.81% <12.72%> (-6.40%) ⬇️
pkg/components/vsphere.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9698478...75d2072. Read the comment docs.

@ahmad-ibra ahmad-ibra marked this pull request as ready for review June 26, 2024 22:55
@ahmad-ibra ahmad-ibra requested a review from a team as a code owner June 26, 2024 22:55
@ahmad-ibra ahmad-ibra merged commit ae596d3 into main Jun 27, 2024
6 of 7 checks passed
@ahmad-ibra ahmad-ibra deleted the feat/setup-validator-config-func branch June 27, 2024 16:34
ahmad-ibra pushed a commit that referenced this pull request Jun 27, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.0.3](v0.0.2...v0.0.3)
(2024-06-27)


### Features

* add helpers to easily configure validator plugins
([#62](#62))
([ae596d3](ae596d3))


### Dependency Updates

* **deps:** update module github.com/vmware/govmomi to v0.38.0
([#59](#59))
([4e6ad15](4e6ad15))
* **deps:** update module gopkg.in/yaml.v2 to v3
([#57](#57))
([9698478](9698478))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants