Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: air-gapped support with hauler #74

Merged
merged 16 commits into from
Jul 15, 2024
Merged

feat: air-gapped support with hauler #74

merged 16 commits into from
Jul 15, 2024

Conversation

TylerGillson
Copy link
Member

@TylerGillson TylerGillson commented Jul 12, 2024 •
edited
Loading

Description

  • use OCI client instead of Helm client due to helm registry login http: server gave HTTP response to HTTPS client helm/helm#12810
  • prompt user for Hauler configuration for air-gapped installs & customize image and chart endpoints accordingly
  • reinstate advanced kind config that was inexplicably removed
  • fix containerdConfigPatches for insecure registries in kind cluster template
  • bump kindest/node image
  • bump kube-rbac-proxy images

Requires:

@TylerGillson TylerGillson mentioned this pull request Jul 12, 2024
Merged
TylerGillson added a commit to validator-labs/validator that referenced this pull request Jul 12, 2024
@TylerGillson
feat: air-gapped support with Hauler (#322)
4cd726d 
## Description
- pull charts from OCI using an OCI client instead of Helm client, due
to helm/helm#12810

Related:
- validator-labs/validatorctl#74

---------

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson TylerGillson marked this pull request as ready for review July 12, 2024 21:36
@TylerGillson TylerGillson requested a review from a team as a code owner July 12, 2024 21:36
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. new-feature Net-new feature labels Jul 12, 2024
@TylerGillson
feat: hauler support for air-gap
ac1c94d 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson
Copy link
Member Author

@ahmad-ibra this is ready for review, but I still need to update the integration tests

@TylerGillson
chore: make reviewable
8a19341 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson
fix: make basic auth optional
b64b1e9 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson
feat: auto-discover default host addr
a1716ad 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson
fix: use ProxyCACert in kind template, add log headers, set UseFixedV…
ba6b698 
…ersions

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jul 15, 2024
@TylerGillson
fix: remove config file changed from stdout
4eb4b43 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson
fix: set UseFixedVersions properly for air-gapped
1945c47 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson
chore: improve stdout headers
5f7c2ad 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson
chore: improve stdout headers
24e8da8 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson
test: fix kind config test
b64dcaa 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson
feat: reconfig username only for vSphere privilege rules
acb025f 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson
fix: update test data; include air-gap settings in password update
5f07a7a 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Jul 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 24.47257% with 179 lines in your changes missing coverage. Please review.

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   53.84%   52.64%   -1.21%     
==========================================
  Files          42       44       +2     
  Lines        4585     4745     +160     
==========================================
+ Hits         2469     2498      +29     
- Misses       1487     1609     +122     
- Partials      629      638       +9
Files Coverage Δ
cmd/root.go 69.64% <100.00%> (ø)
pkg/config/constants.go 100.00% <100.00%> (ø)
pkg/services/validator/aws.go 51.66% <100.00%> (+0.08%) ⬆️
pkg/services/validator/azure.go 61.59% <100.00%> (+0.09%) ⬆️
pkg/services/validator/network.go 48.42% <100.00%> (+0.18%) ⬆️
pkg/services/validator/oci.go 45.83% <100.00%> (+0.25%) ⬆️
...integration/_validator/testcases/test_validator.go 94.81% <100.00%> (+0.01%) ⬆️
pkg/components/network.go 0.00% <0.00%> (ø)
pkg/components/oci.go 0.00% <0.00%> (ø)
pkg/components/vsphere.go 0.00% <0.00%> (ø)
... and 8 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b6f978...cbdb481. Read the comment docs.

@TylerGillson
fix: remove selected ESXi hosts; fix readEntity reconfig
b576caa 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson
fix: wording
a723ffd 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson @ahmad-ibra
chore: Update pkg/services/env_service.go
8fceac7 
Co-authored-by: Ahmad Malik Ibrahim <ahmad.ibrahim@spectrocloud.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson
chore: make reviewable
cbdb481 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
ahmad-ibra
ahmad-ibra approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@ahmad-ibra ahmad-ibra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 15, 2024
@TylerGillson TylerGillson merged commit aa3fd73 into main Jul 15, 2024
6 of 7 checks passed
@TylerGillson TylerGillson deleted the feat/hauler branch July 15, 2024 18:20
@TylerGillson TylerGillson mentioned this pull request Jul 10, 2024
Merged
TylerGillson added a commit that referenced this pull request Jul 15, 2024
@TylerGillson
chore(main): release 0.0.4 (#66)
ed99a78 
🤖 I have created a release *beep* *boop*
---


##
[0.0.4](v0.0.3...v0.0.4)
(2024-07-15)


### Features

* air-gapped support with hauler
([#74](#74))
([aa3fd73](aa3fd73))


### Dependency Updates

* **deps:** update actions/setup-go digest to 0a12ed9
([#72](#72))
([7b6f978](7b6f978))
* **deps:** update anchore/sbom-action action to v0.16.1
([#71](#71))
([347da36](347da36))
* **deps:** update golang.org/x/exp digest to 46b0784
([#67](#67))
([89caf1c](89caf1c))
* **deps:** update module github.com/validator-labs/validator to v0.0.46
([#73](#73))
([72897c2](72897c2))
* **deps:** update module github.com/validator-labs/validator-plugin-aws
to v0.1.1
([#68](#68))
([bba7058](bba7058))
* **deps:** update module
github.com/validator-labs/validator-plugin-azure to v0.0.12
([#70](#70))
([e1bf9fa](e1bf9fa))
* **deps:** update module gopkg.in/yaml.v2 to v3
([#61](#61))
([8952d08](8952d08))


### Refactoring

* enable revive and address all lints
([#69](#69))
([b9c8df8](b9c8df8))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmad-ibra ahmad-ibra ahmad-ibra approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer new-feature Net-new feature size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TylerGillson @ahmad-ibra