feat: isEmail: validate display name using standards of RFC2822 #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
profnandaa
approved these changes
Apr 10, 2019
There was a problem hiding this comment.
LGTM. Will prefer a second look from @chriso or someone else and will be glad to land it.
Thanks for the PR! 👍
profnandaa
added
🍿 discussion
ready-to-land
|
Any update? |
|
Really need this PR to be merged. 🙏 |
gongbaodd
approved these changes
May 23, 2019
tallguys
approved these changes
May 23, 2019
|
Looks good – thanks for the PR 😄 |
|
I'll push a new version very soon. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue: #976
Currently, the validation rule of a display name is not such standard, I have found out the standard of display name.
Refer to the RFC2822: https://tools.ietf.org/html/rfc2822#appendix-A.1.2
The display name of an email address can be any characters(but I ruled out invisible characters in the code),
if there is any illegal character such as angled-brackets/quotes/semicolon, must enclose the display name in double-quotes,
quotes in display name should start with a backslash
And thanks for the contributions you all guys, benefit a lot!