Code coverage improvements

[tux-tn]

Hello,

This PR contains various changes:

• isISO8601: added a fix for leap years checking where years divisible by 400 where not handled correctly and removed a never met condition
• isDecimal: fixed decimal point type for Egypt, Libya, Lebanon and South Africa according to the existing Wikipedia source
• rtrim and ltrim: refactored rtrim to use the same logic and added char escaping to avoid ReDOS and unwanted behavior and chars parsing by Regexp (Using \S as chars for example)
• isIdentityCard: removed the default value for locale to follow the same behavior of other validators like isPostalCode
• Added Exception testing: a new attribute error in test function add possibility to check for thrown error in validators, mainly used in working with non-existing locales.

Not very confident about adding tooling/dependencies without prior discussions but I also added istanbul/nyc , it helped me to find and fix unhandled conditions and cases and may be very useful for validator.js PRs when linked with Codecov or Coverall.

Coverage before changes:

=============================== Coverage summary ===============================
Statements   : 97.39% ( 933/958 )
Branches     : 94.5% ( 567/600 )
Functions    : 100% ( 89/89 )
Lines        : 97.53% ( 908/931 )
================================================================================

Coverage after changes:

=============================== Coverage summary ===============================
Statements   : 100% ( 953/953 )
Branches     : 100% ( 586/586 )
Functions    : 100% ( 89/89 )
Lines        : 100% ( 926/926 )
================================================================================

[tux-tn]

@profnandaa I have some other little fixes, should i open a new PR or push to this one?

[profnandaa]

Sure, can make it a separate PR.

-na

On Sat, May 25, 2019 at 2:08 PM Sarhan Aissi ***@***.***> wrote: @profnandaa <https://github.com/profnandaa> I have some other little fixes, should i open a new PR or push to this one? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1024>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAB7ZEOJAFII2XK2JNYFGH3PXEMZFANCNFSM4HK4FBGQ> .

-- Sent from a tiny device while on the move.

[profnandaa]

LGTM

[profnandaa]

@tux-tn -- sorry for my delay to reviewing this. Please fix the merge conflicts and we should land.

[tux-tn]

@tux-tn thank you for taking time to look into this, my branch is now up to date with master

[tux-tn]

@profnandaa can we add a tool like Coveralls or Codecov to handle coverage change in future PRs?

[profnandaa]

Good idea, for sure. Please open an issue for this, I'll follow up with @chriso

…

On Tue, Jun 18, 2019 at 6:48 PM Sarhan Aissi ***@***.***> wrote: @profnandaa <https://github.com/profnandaa> can we add a tool like Coveralls or Codecov to handle coverage change in future PRs? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1024>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAB7ZEJ23XVQWD7VCSZBQS3P3D7TNANCNFSM4HK4FBGQ> .

-- *Nandaa **Anthony* *,*Software Craftsman & Mentor *Twitter/Github: *@profnandaa <http://twitter.com/profnandaa> *Blog: *www.nandaa.com <http://nandaa.com>